Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 5D9C3200D59 for ; Sun, 10 Dec 2017 17:33:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 5BFFD160C09; Sun, 10 Dec 2017 16:33:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 82D7F160BF2 for ; Sun, 10 Dec 2017 17:33:36 +0100 (CET) Received: (qmail 91858 invoked by uid 500); 10 Dec 2017 16:33:35 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 91847 invoked by uid 99); 10 Dec 2017 16:33:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Dec 2017 16:33:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D9F3E18070F for ; Sun, 10 Dec 2017 16:33:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.749 X-Spam-Level: *** X-Spam-Status: No, score=3.749 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id gbYus6zt1zD3 for ; Sun, 10 Dec 2017 16:33:32 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 13E115F2EE for ; Sun, 10 Dec 2017 16:33:32 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 54258E0162; Sun, 10 Dec 2017 16:33:31 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 52224C40641; Sun, 10 Dec 2017 16:33:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2025112301075042843==" MIME-Version: 1.0 Subject: Re: Review Request 64290: Update to Thrift 0.10.0 From: John Sirois To: Bill Farner , Stephan Erb Cc: Aurora , John Sirois Date: Sun, 10 Dec 2017 16:33:28 -0000 Message-ID: <20171210163328.16833.86528@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: John Sirois X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/64290/ X-Sender: John Sirois References: <20171209163250.6998.20123@reviews-vm2.apache.org> In-Reply-To: <20171209163250.6998.20123@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/test/python/apache/aurora/client/cli/__init__.py X-ReviewBoard-Diff-For: src/test/python/apache/aurora/common/health_check/__init__.py X-ReviewBoard-Diff-For: src/test/python/apache/aurora/client/docker/__init__.py X-ReviewBoard-Diff-For: build-support/thrift/Makefile X-ReviewBoard-Diff-For: src/test/python/apache/aurora/executor/common/__init__.py X-ReviewBoard-Diff-For: src/test/python/apache/aurora/client/__init__.py X-ReviewBoard-Diff-For: src/test/python/apache/aurora/admin/__init__.py X-ReviewBoard-Diff-For: src/test/python/apache/aurora/client/api/__init__.py X-ReviewBoard-Diff-For: src/test/python/apache/aurora/client/binding_helpers/__init__.py X-ReviewBoard-Diff-For: build-support/thrift/AURORA-1727.lib.py.setup.py.patch X-ReviewBoard-Diff-For: build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch X-ReviewBoard-Diff-For: build-support/thrift/prepare_binary.sh X-ReviewBoard-Diff-For: build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch X-ReviewBoard-Diff-For: build-support/python/isort X-ReviewBoard-Diff-For: src/test/python/apache/aurora/__init__.py X-ReviewBoard-Diff-For: build-support/thrift/BUILD Reply-To: John Sirois X-ReviewRequest-Repository: aurora archived-at: Sun, 10 Dec 2017 16:33:37 -0000 --===============2025112301075042843== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64290/#review193356 ----------------------------------------------------------- @ReviewBot retry - John Sirois On Dec. 9, 2017, 9:32 a.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64290/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2017, 9:32 a.m.) > > > Review request for Aurora, Stephan Erb and Bill Farner. > > > Repository: aurora > > > Description > ------- > > Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES) > > Included changes: > > * Update to the latest pants version. This was necesary to get ./pants gen working. > * The Java hashcode option has been removed as it is now the default. > > > Diffs > ----- > > .isort.cfg f53ccba7d1d45adcb4753cfd05c53bbec5c89dde > 3rdparty/python/requirements.txt 85a23d7770d82bfc74b1fc847170a8779dd7249f > api/src/main/thrift/org/apache/aurora/gen/BUILD 835b0cc6f51a592f7d5b6129dbe9519455eb6555 > api/src/main/thrift/org/apache/thermos/BUILD b58338e76bdee3481071d8f27235a9dbb6bf07b5 > build-support/jenkins/build.sh f59fe278aea55fc3ffa1b5dff7b686cfcfae1ee7 > build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac > build-support/python/checkstyle-check 0c8800232e20347b2be9a538ffed1d47a7815241 > build-support/python/isort 37e6cd23d2437055a15abfec6924c1bdd051de20 > build-support/python/isort-check a1bb94c99250f54f8fc261fb311cd34ce8355c78 > build-support/python/isort-run 1b39d41212d6e870c55d420a9d844fd67dd40eae > build-support/release/make-python-sdists 51e11dbc1929609374031c9b23a96f035eba902b > build-support/thrift/.gitignore 82c5bc5cd773ecf3ec194de41a340a3ef9b83aa5 > build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689 > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529 > build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6 > build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760 > build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8 > build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 > build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1 > build.gradle 76dcc040a822db2e209646e62b71ae45bf3f4793 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67 > pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc > src/main/python/apache/aurora/client/cli/BUILD 80a6dec9acf5b64cff64143929916676b79be686 > src/main/python/apache/thermos/observer/BUILD 95b8dcd7d123d3a2bcb22df7efc60374ef919bf7 > src/test/python/apache/aurora/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/admin/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/api/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/binding_helpers/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/cli/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/client/docker/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/common/health_check/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/aurora/executor/common/__init__.py 0663a9ad8ae194b63ce6d77dabfe65564e2d26dd > src/test/python/apache/thermos/core/test_process.py 6cb9176e14eccbe7ed10501199a34e5e67d6fe44 > > > Diff: https://reviews.apache.org/r/64290/diff/4/ > > > Testing > ------- > > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > > --===============2025112301075042843==--