Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============3563146879631501115=="
MIME-Version: 1.0
Subject: Re: Review Request 63750: pants for high-sierra
From: Bill Farner <wfarner@apache.org>
To: Bill Farner <wfarner@apache.org>, John Sirois <jsirois@apache.org>
Cc: Aurora ReviewBot <wfarner@apache.org>, Stephan Erb <serb@apache.org>,
 se choi <thinker0@gmail.com>, Aurora <reviews@aurora.apache.org>
Date: Mon, 04 Dec 2017 00:47:58 -0000
Message-ID: <20171204004758.20853.12182@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Bill Farner <noreply@reviews.apache.org>
References: <20171115001342.16899.55086@reviews-vm2.apache.org>
In-Reply-To: <20171115001342.16899.55086@reviews-vm2.apache.org>
Reply-To: Bill Farner <wfarner@apache.org>
archived-at: Mon, 04 Dec 2017 00:48:06 -0000

--===============3563146879631501115==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Nov. 14, 2017, 4:13 p.m., Aurora ReviewBot wrote:
> > Master (4fecf1f) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > WARN] /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.4.0.dev20/local/lib/python2.7/site-packages/pants/build_graph/build_file_aliases.py:52: DeprecationWarning: DEPRECATED: The `resources=` Python target argument found on target src/main/python/apache/aurora/client/cli:auroraversion will be removed in version 1.5.0.dev0.
> >   Depend on resources targets instead.
> >   context_aware_object_factory(parse_context, *args, **kwargs)
> > 
> > WARN] /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.4.0.dev20/local/lib/python2.7/site-packages/pants/engine/legacy/graph.py:173: DeprecationWarning: DEPRECATED: The `resources=` Python target argument found on target src/main/python/apache/thermos/observer:observer will be removed in version 1.5.0.dev0.
> >   Depend on resources targets instead.
> >   return target_cls(build_graph=self, **kwargs)
> > 
> > WARN] /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.4.0.dev20/local/lib/python2.7/site-packages/pants/engine/legacy/graph.py:173: DeprecationWarning: DEPRECATED: The `resources=` Python target argument found on target src/main/python/apache/aurora/client/cli:auroraversion will be removed in version 1.5.0.dev0.
> >   Depend on resources targets instead.
> >   return target_cls(build_graph=self, **kwargs)
> > 
> > 
> > 00:13:35 00:00 [main]
> >                (To run a reporting server: ./pants server)
> > 00:13:35 00:00   [setup]
> > 00:13:36 00:01     [parse]
> >                Executing tasks in goals: gen -> pyprep -> test
> > 00:13:36 00:01   [gen]
> > 00:13:36 00:01     [thrift-py]
> > 00:13:36 00:01       [cache]    
> >                    No cached artifacts for 4 targets.
> >                    Invalidated 4 targets.INFO] Attempting to fetch thrift binary from: /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/serve/bin/thrift/linux/x86_64/0.9.1/thrift ...
> > 
  2% .                                                   180 KB
  4% ..                                                  350 KB
  6% ...                                                 520 KB
  8% ....                                                700 KB
 10% .....                                               870 KB
 12% ......                                             1040 KB
 14% .......                                            1210 KB
 16% ........                                           1390 KB
 18% .........                                          1560 KB
 20% ..........                                         1730 KB
 22% ...........                                        1900 KB
 24% ............                                       2080 KB
 26% .............                                      2250 KB
 28% ..............                                     2420 KB
 30% ...............                                    2590 KB
 32% ................                                   2770 KB
 34% .................                                  2940 KB
 36% ..................                                 3110 KB
 38% ...................                                3280 KB
 40% ....................                               3460 KB
 42% .....................                              3630 KB
 44% ......................                             3800 KB
 46% .......................                            3970 KB
 48% ........................                           4150 KB
 50% .........................                          4320 KB
 52% ..........................                         4490 KB
 54% ...........................                        4660 KB
 56% ............................                       4840 KB
 58% .............................                      5010 KB
 60% ..............................                     5180 KB
 62% ...............................                    5350 KB
 64% ................................                   5530 KB
 66% .................................                  5700 KB
 68% ..................................                 5870 KB
 70% ...................................                6040 KB
 72% ....................................               6220 KB
 74% .....................................              6390 KB
 76% ......................................             6560 KB
 78% .......................................            6740 KB
 80% ........................................           6910 KB
 82% .........................................          7080 KB
 84% ..........................................         7250 KB
 86% ...........................................        7430 KB
 88% ............................................       7600 KB
 90% .............................................      7770 KB
 92% ..............................................     7940 KB
 94% ...............................................    8120 KB
 96% ................................................   8290 KB
 98% .................................................  8460 KB
100% .................................................. 8628 KB 0.032s
> > INFO] Fetched thrift binary from: /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/serve/bin/thrift/linux/x86_64/0.9.1/thrift .
> > ....
> > 00:13:36 00:01   [pyprep]
> > 00:13:36 00:01     [interpreter]
> > 00:13:40 00:05     [requirements]
> > 00:13:40 00:05       [cache]                                   
> >                    No cached artifacts for 35 targets.
> >                    Invalidated 35 targets.
> >                Waiting for background workers to finish.
> > 00:13:41 00:06   [complete]
> >                FAILURE
> > Exception caught: (<class 'pex.resolver.Unsatisfiable'>)
> > 
> > Exception message: Could not satisfy all requirements for mesos.executor==1.4.0:
> >     mesos.executor==1.4.0
> > 
> > 
> > 
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
> 
> Bill Farner wrote:
>     I'm not certain if pex resolution is also affected, but you may want to see this issue: https://issues.apache.org/jira/browse/MESOS-8224
> 
> Stephan Erb wrote:
>     I have been looking into this a bit, but still haven't figured it out.
>     
>     It seems like pants changed when it tries to resolve dependencies. The `mesos.executor` only used to be pulled in when building the executor binary. In newer version, pants will check for the existance of the dependency even if it is not needed at all, i.e. during test executions. The dependency is only available when explicitly downloaded beforehand, so the build fails on Jenkins.
> 
> John Sirois wrote:
>     I've got a fix ... I'll post a diff here later tonight, but wrt https://reviews.apache.org/r/62590
>     Basically, the current build.sh test command is at fault, executing against `src/{main,test}/python::` (which explicitly depends on the problematic thermos binary that in turn depends on `mesos.executor`) instead of `src/test/python::`.

> `src/{main,test}/python::`

Aha!  This makes some sense.  Thanks for following along, John!


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63750/#review191018
-----------------------------------------------------------


On Nov. 14, 2017, 3:51 p.m., se choi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63750/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 3:51 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> pants for high-sierra
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618 
>   pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc 
> 
> 
> Diff: https://reviews.apache.org/r/63750/diff/2/
> 
> 
> Testing
> -------
> 
> Review homebrew-core
> 
> https://github.com/Homebrew/homebrew-core/pull/20581
> 
> 
> Thanks,
> 
> se choi
> 
>


--===============3563146879631501115==--