aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <>
Subject Re: Review Request 64523: Attempt #2 to fix flaky Webhook test
Date Tue, 12 Dec 2017 19:15:45 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 12, 2017, 7:15 p.m.)

Review request for Aurora and Stephan Erb.


Attempt #3

Bugs: AURORA-1961

Repository: aurora

Description (updated)

Attempt #2 to fix the flaky Webhook test.

Along the same lines of Stephan's change (, but waiting
for `onThrowable` to finish since it is called asyncronously to the future being completed.

Overall, this flakiness has seemed to increase in volume over the past month. I've been running
into it with a noticable fraction of internal/test builds.

Diffs (updated)

  src/test/java/org/apache/aurora/scheduler/events/ 1b5d2d02535345edfe6cf04d18d00434393f800b



Testing (updated)

This change seems pretty hard to test considering the differences in environment and the unknown
cause of the actual errors. Maybe we run the reviewbot on this repo repeatedly? Obviously
not the most scientifically sound solution.

EDIT 12/12: I tested this by putting a long sleep in `onThrowable` which causes the issue
in master and is fixed with this patch.


Jordan Ly

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message