aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <jordan....@gmail.com>
Subject Review Request 64459: Deprecated Ops re-added, perform no-op instead of throwing an exception
Date Fri, 08 Dec 2017 20:06:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64459/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner.


Repository: aurora


Description
-------

Deprecated Ops re-added, perform no-op instead of throwing an exception


Diffs
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift c9f42108e85af563ef584f3b60c0ec2ceb3f0bb6

  api/src/main/thrift/org/apache/aurora/gen/storage.thrift 22104979ce8844929f439c44b0f4c63bf90f07d7

  src/main/java/org/apache/aurora/scheduler/storage/durability/DurableStorage.java 85b2113631586f43d854c4d2812f43b7b864d452

  src/test/java/org/apache/aurora/scheduler/storage/durability/DurableStorageTest.java 07912b6a8ffb4bd3f87861f8c17242f6056aaf49



Diff: https://reviews.apache.org/r/64459/diff/1/


Testing
-------

`./gradlew test`

I tested by reproducing the issue (adding a job update) and then replaying the log. Before
the patch, the scheduler crashed on `recover`. This patch succeeded.


Thanks,

Jordan Ly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message