aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 64359: Fix for multiple slf4j jars in intellij
Date Wed, 06 Dec 2017 04:46:22 GMT


> On Dec. 5, 2017, 8:38 p.m., Jordan Ly wrote:
> > build.gradle
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/64359/diff/1/?file=1909391#file1909391line121>
> >
> >     is this used?

It is.  Since we're now strict about dependency versions in the test classpath, we'll have
to force transitive test deps as well.
```console
> Could not resolve all dependencies for configuration ':testCompileClasspath'.
   > A conflict was found between the following modules:
      - org.objenesis:objenesis:2.2
      - org.objenesis:objenesis:2.1
```


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64359/#review192965
-----------------------------------------------------------


On Dec. 5, 2017, 7:55 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64359/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2017, 7:55 p.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I finally decided to dig into the cause of multiple slf4j jars causing trouble running
tests in intellij.  Turns out that while we are strict about dependency versions for the `compile`
configuration, the build allowed version conflicts in the `test` configuration.  This led
to multiple slf4j versions.
> 
> 
> Diffs
> -----
> 
>   build.gradle af119910e84c48f75f2573ababcfa287c3b986fc 
> 
> 
> Diff: https://reviews.apache.org/r/64359/diff/1/
> 
> 
> Testing
> -------
> 
> `./gradlew idea`, 'External Libraries' no longer has rogue slf4j jars, and tests don't
fail as a result.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message