aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 64288: Add a SQL persistence implementation
Date Mon, 04 Dec 2017 20:02:04 GMT


> On Dec. 4, 2017, 10:40 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/sql/SqlPersistence.java
> > Lines 73 (patched)
> > <https://reviews.apache.org/r/64288/diff/1/?file=1907266#file1907266line73>
> >
> >     Can this just be `DataSource dataSource` since we're not using it for anything
other than `getConnection` and `close`?

`DataSource` does not have `close()` unfortunately.  Didn't want to bother with any clever
layering to hide it and get `close()`.


> On Dec. 4, 2017, 10:40 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/storage/sql/SqlPersistence.java
> > Lines 161 (patched)
> > <https://reviews.apache.org/r/64288/diff/1/?file=1907266#file1907266line161>
> >
> >     Does MySQL support `NULLS FIRST`? I don't see any mention of it in their docs,
and trying on a local MySQL instance (5.7.x) it doesn't seem to work?

You're right, it doesn't.  This type of issue will be naturally flushed out as the code is
exercised against a real MySQL server (which, if we continue down this path, will happen in
integration tests).  I've got an updated patch incoming that fixes some issues discovered
in the course of the benchmarking done above.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64288/#review192722
-----------------------------------------------------------


On Dec. 3, 2017, 5:09 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64288/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2017, 5:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Introduces a `Persistence` implementation that uses a SQL database via JDBC.  I've opted
to lean towards MySQL SQL dialect, as unfortunately there are vendor differences for even
the very simple SQL used here.
> 
> I chose [HikariCP](https://github.com/brettwooldridge/HikariCP) to serve as a `DataSource`
(connection pool) implementation.  We don't really need much out of a connection pool aside
from general connection lifecycle management (i.e. not for concurrency).  I chose this library
based on recent development activity and several positive comparisons to other pools.
> 
> Note that the implementation is not yet wired into the scheduler application.  That will
come in a follow-up.
> 
> 
> Diffs
> -----
> 
>   build.gradle af119910e84c48f75f2573ababcfa287c3b986fc 
>   config/spotbugs/excludeFilter.xml 51790cce8d9047e40741f05ee55af15dbdc3065e 
>   src/main/java/org/apache/aurora/scheduler/storage/durability/DurableStorage.java 85b2113631586f43d854c4d2812f43b7b864d452

>   src/main/java/org/apache/aurora/scheduler/storage/durability/Persistence.java 9eb862c01bf451252bfbcc7a2eac60d2c965c9f0

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogPersistence.java e70e6051582ca90ae72014626b983bbf4b8d5b48

>   src/main/java/org/apache/aurora/scheduler/storage/sql/SqlPersistence.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/sql/SqlPersistenceModule.java PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/storage/sql/schema.sql PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/storage/sql/SqlPersistenceTest.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/64288/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message