aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 64288: Add a SQL persistence implementation
Date Mon, 04 Dec 2017 01:57:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64288/#review192664
-----------------------------------------------------------


Ship it!




Master (89338dd) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 3, 2017, 5:09 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64288/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2017, 5:09 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Introduces a `Persistence` implementation that uses a SQL database via JDBC.  I've opted
to lean towards MySQL SQL dialect, as unfortunately there are vendor differences for even
the very simple SQL used here.
> 
> I chose [HikariCP](https://github.com/brettwooldridge/HikariCP) to serve as a `DataSource`
(connection pool) implementation.  We don't really need much out of a connection pool aside
from general connection lifecycle management (i.e. not for concurrency).  I chose this library
based on recent development activity and several positive comparisons to other pools.
> 
> Note that the implementation is not yet wired into the scheduler application.  That will
come in a follow-up.
> 
> 
> Diffs
> -----
> 
>   build.gradle af119910e84c48f75f2573ababcfa287c3b986fc 
>   config/spotbugs/excludeFilter.xml 51790cce8d9047e40741f05ee55af15dbdc3065e 
>   src/main/java/org/apache/aurora/scheduler/storage/durability/DurableStorage.java 85b2113631586f43d854c4d2812f43b7b864d452

>   src/main/java/org/apache/aurora/scheduler/storage/durability/Persistence.java 9eb862c01bf451252bfbcc7a2eac60d2c965c9f0

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogPersistence.java e70e6051582ca90ae72014626b983bbf4b8d5b48

>   src/main/java/org/apache/aurora/scheduler/storage/sql/SqlPersistence.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/sql/SqlPersistenceModule.java PRE-CREATION

>   src/main/resources/org/apache/aurora/scheduler/storage/sql/schema.sql PRE-CREATION

>   src/test/java/org/apache/aurora/scheduler/storage/sql/SqlPersistenceTest.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/64288/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message