aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 64234: Extract a storage Persistence layer
Date Sat, 02 Dec 2017 20:34:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64234/#review192634
-----------------------------------------------------------



@ReviewBot retry

- Bill Farner


On Nov. 30, 2017, 4:32 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64234/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2017, 4:32 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This extracts the `Log`- and `Snapshot`-specific details from `LogStorage`,
> leaving `DurableStorage`.  `DurableStorage` is useful as a general-purpose
> `Storage` mutation observer, with `Persistence` being the minimal behavior
> needed for an underlying durability layer to provide.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 3c12532acca9107f5a54df48fc59348d70af29c6

>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 5fe7b9b11f6ce2307f8e40822d5e2b4de2116450

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java fa2f39cb88499a4fa6dfe3a25574d3f165f530fd

>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java f9dee22bfab04023c2664f301d9ac548d75a8729

>   src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 1b10ec53c7ce72974301e03f095982d25cf069d1

>   src/main/java/org/apache/aurora/scheduler/storage/DistributedSnapshotStore.java 4ddee400760d4a5cbd88a5758d0919bd4fe8dcd2

>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 7d325b6daff091ef6a856749f55a3516d24721fb

>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java 6cd5b2b8a10cb6b3f54d2fd270cda6774c714ace

>   src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java 30007968870900deb9689344b5ac84d535c7149a

>   src/main/java/org/apache/aurora/scheduler/storage/durability/Persistence.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/durability/TransactionRecorder.java
PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogPersistence.java PRE-CREATION

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 07b4bdb1b466b37b96eeb866dfebd8e5a70032ac

>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java c8dc7ad141f27318f18afdc440250afc42f0bc6d

>   src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 5859f803e840959af2dead550a0d7f241d3d42be

>   src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java ea147c0ba6aaa6d113144be0a8330bd2f73d2453

>   src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java baf2647c54f1f9918139584e5151873a3853e83c

>   src/main/java/org/apache/aurora/scheduler/storage/log/ThriftBackfill.java 92b64bb2039585d0cc13905d9f5f01b9759c214a

>   src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java 41061f8afb824316dbaf1027e206424ebff0ed83

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 2cc567dec52652ee2d874bc97af676e57b0a35f9

>   src/test/java/org/apache/aurora/scheduler/app/local/FakeNonVolatileStorage.java 8cf68714c10102209639743fe3223406134cc4d7

>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java c639ab652d0c094a5facea31c77f528ed179ab00

>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 7138d6b355a87a8ee320696547527942f43b9ad5

>   src/test/java/org/apache/aurora/scheduler/storage/durability/TransactionRecorderTest.java
PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 3f445595a81a5655c6c486791a9b55d8dc7f2f76

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 3c056c966b93335eee3a1386cd096b6419f5e319

>   src/test/java/org/apache/aurora/scheduler/storage/log/NonVolatileStorageTest.java f43a836a4176c465fa3f496c77ef6dc1cbc1691a

>   src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java a1944c4fdaa5bc578a7c1430f6304eae5d8a5f08

>   src/test/java/org/apache/aurora/scheduler/storage/log/ThriftBackfillTest.java 59c2c5bb1a4bea125ae799d76179946b722fc150

>   src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java 8a99b36757a25f58773c5445c046c4f9f9158056

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
42a79a6ca6ee0f51b7d1a4ac1df9dbd555f2d2b9 
>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java b2c371cde5eec186a1bbfbfc8a0555f9930a6791

> 
> 
> Diff: https://reviews.apache.org/r/64234/diff/3/
> 
> 
> Testing
> -------
> 
> end-to-end tests pass
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message