Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2C817200D4A for ; Tue, 14 Nov 2017 01:17:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B0EAD160C06; Tue, 14 Nov 2017 00:17:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 01869160BF3 for ; Tue, 14 Nov 2017 01:17:16 +0100 (CET) Received: (qmail 21363 invoked by uid 500); 14 Nov 2017 00:17:15 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 21344 invoked by uid 99); 14 Nov 2017 00:17:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Nov 2017 00:17:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id C4621C11BC; Tue, 14 Nov 2017 00:17:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3 X-Spam-Level: *** X-Spam-Status: No, score=3 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Qok51osBkiog; Tue, 14 Nov 2017 00:17:13 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 468795F6C8; Tue, 14 Nov 2017 00:17:13 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D8136E0AA3; Tue, 14 Nov 2017 00:17:12 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id D05FCC40DC2; Tue, 14 Nov 2017 00:17:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3218028413411640091==" MIME-Version: 1.0 Subject: Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest From: Aurora ReviewBot To: Bill Farner Cc: Aurora ReviewBot , Aurora , Jordan Ly Date: Tue, 14 Nov 2017 00:17:12 -0000 Message-ID: <20171114001712.48145.36985@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63763/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20171113235832.24895.868@reviews-vm2.apache.org> In-Reply-To: <20171113235832.24895.868@reviews-vm2.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Tue, 14 Nov 2017 00:17:28 -0000 --===============3218028413411640091== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63763/#review190910 ----------------------------------------------------------- Ship it! Master (fb64df2) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Nov. 13, 2017, 3:58 p.m., Jordan Ly wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63763/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2017, 3:58 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > In the same vein as: https://reviews.apache.org/r/63760/ > > Fix a flaky test that uses `Thread.sleep` by injecting a fake Executor. > > > Diffs > ----- > > src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 8f8b86dfb5d53439671ca59e6c42245b31fc6136 > > > Diff: https://reviews.apache.org/r/63763/diff/2/ > > > Testing > ------- > > `./gradlew test` > > > Thanks, > > Jordan Ly > > --===============3218028413411640091==--