Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CEEE7200D33 for ; Wed, 8 Nov 2017 18:56:55 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CD553160BDA; Wed, 8 Nov 2017 17:56:55 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1E2481609E0 for ; Wed, 8 Nov 2017 18:56:54 +0100 (CET) Received: (qmail 49480 invoked by uid 500); 8 Nov 2017 17:56:54 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 49456 invoked by uid 99); 8 Nov 2017 17:56:54 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 17:56:54 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id DD259EDAE5; Wed, 8 Nov 2017 17:56:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.701 X-Spam-Level: **** X-Spam-Status: No, score=4.701 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, NML_ADSP_CUSTOM_MED=1.2, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id coQ8UdKVHeIM; Wed, 8 Nov 2017 17:56:52 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0523261216; Wed, 8 Nov 2017 17:56:52 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9CF6EE041F; Wed, 8 Nov 2017 17:56:51 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 97F9EC40191; Wed, 8 Nov 2017 17:56:51 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5903476296107209492==" MIME-Version: 1.0 Subject: Re: Review Request 63670: Add a test for storage durability From: Jordan Ly To: Jordan Ly Cc: Bill Farner , Aurora Date: Wed, 08 Nov 2017 17:56:51 -0000 Message-ID: <20171108175651.35837.61391@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Jordan Ly X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63670/ X-Sender: Jordan Ly X-ReviewBoard-ShipIt: 1 References: <20171108161329.35837.83529@reviews-vm2.apache.org> In-Reply-To: <20171108161329.35837.83529@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/storage/log/FakeLog.java Reply-To: Jordan Ly X-ReviewRequest-Repository: aurora archived-at: Wed, 08 Nov 2017 17:56:56 -0000 --===============5903476296107209492== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63670/#review190462 ----------------------------------------------------------- Ship it! src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java Lines 59 (patched) I might name this NonVolatileStorageTest for consistency, and since I believe you are essentially only testing this interface. - Jordan Ly On Nov. 8, 2017, 4:13 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63670/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 4:13 p.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > Introduces a new test that validates the durability of the storage system as a whole. Since we cannot count on loading the mesos JNI lib, a `FakeLog` is introduced to represent the durable layer. Additionally, the high-level nature of this test should allow it to serve as a conformance test when new storage layer implementations are added. > > I also removed the `Comparable` interface from `Log.Position`, as it was never used. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/log/Log.java dc77eb435e5f8fdce56727a2f679e8e1907e977c > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java 21855e184fe20dc339713978b32344b6950701ec > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 67a0d5a7da90dc01b7a962c2f21730b4be06895a > src/test/java/org/apache/aurora/scheduler/log/mesos/MesosLogTest.java f142f545799d64f9352b0ac6c51942eedf5e9ced > src/test/java/org/apache/aurora/scheduler/storage/log/DurableStorageTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/storage/log/FakeLog.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/63670/diff/1/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============5903476296107209492==--