aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Renan DelValle <renanidelva...@gmail.com>
Subject Re: Review Request 64190: Moved `HostOffer` to `offers` package
Date Thu, 30 Nov 2017 18:48:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64190/#review192328
-----------------------------------------------------------


Ship it!




Ship It!

- Renan DelValle


On Nov. 29, 2017, 4:59 p.m., Jordan Ly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64190/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2017, 4:59 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Small refactor, I think it fits better here as opposed to the top-level package.
> 
> 
> Diffs
> -----
> 
>   src/jmh/java/org/apache/aurora/benchmark/Offers.java 2fcc804a09080d7103afd175d5fb7490ab3cc967

>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 58e3224e62a637e659f89f90af4244460c9606af

>   src/jmh/java/org/apache/aurora/benchmark/fakes/FakeOfferManager.java 05c58ab2d82fafd8c2d933b29d2794758fa2e7f1

>   src/main/java/org/apache/aurora/scheduler/HostOffer.java d7d9773149d99b61ee52333e413a2159e2f19858

>   src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java a00c095a792da87727590685f434be36de0ecfbb

>   src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 87e702ff4358c3172a222e0dcf40fc2df0937100

>   src/main/java/org/apache/aurora/scheduler/offers/HostOffers.java 8adbcb171dc20e11bdad0db3757768ee87ece8c9

>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 0349215f998b745e1ac9ab43ba971a190d90d8db

>   src/main/java/org/apache/aurora/scheduler/offers/OfferManagerImpl.java 427b1b4bb8889823d2c1aac79f9969a28c1fb98a

>   src/main/java/org/apache/aurora/scheduler/offers/OfferManagerModule.java e2e3628f940558c586396b6dff84540792f514c8

>   src/main/java/org/apache/aurora/scheduler/offers/OfferOrderBuilder.java 9b395fa86a38e51bf002c956b49b29b76e131eb9

>   src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java 838a3191903564213dae98e5e564525fc0e20fad

>   src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java 497a766c085bae24cf77d611aceb25b51da49cb7

>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 13ccbffb150c67fee97b7ca6a1eaa29bb2f33a7b

>   src/main/java/org/apache/aurora/scheduler/scheduling/FirstFitOfferSelector.java ee65bab081ecc5b1542f312ccaafd4911d441b11

>   src/main/java/org/apache/aurora/scheduler/scheduling/OfferSelector.java c95b980dd30fcfbce0ee75de8e03ca3e1ef9b5d0

>   src/main/java/org/apache/aurora/scheduler/scheduling/TaskAssignerImpl.java a1dd74f0bb86cb8e759db09ac1da5fcae5c08eb2

>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java e629093523848fa377532d9bdff926db6c95f1bd

>   src/test/java/org/apache/aurora/scheduler/HostOfferTest.java d6e5ff49169e8f2f4a6dafe468136bcc1bf85273

>   src/test/java/org/apache/aurora/scheduler/http/OffersTest.java 549d2e37e130dd249917071781a009eb4385b8af

>   src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 64efc0dd212bf5d12f3ebc0c327635f8b2b19fcc

>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java ff80baa0a83787daa6cb1f3614b7e863bfd960a7

>   src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java a346e446060d22cfa2bd228c7442e7d7f11b4495

>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
fa74fb64710f7ee3d31533a1fcbde24b5eb82e6b 
>   src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorImplTest.java 1061583b9ebbb46202e39a516d77d63a5e9bd369

>   src/test/java/org/apache/aurora/scheduler/scheduling/FirstFitOfferSelectorTest.java
627055c7106206272f34da0c2c9d44abc8a51507 
>   src/test/java/org/apache/aurora/scheduler/scheduling/TaskAssignerImplTest.java e0949509762faff9c0cf0da38ca74e3a069aa726

>   src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java dfcbb4ad0a91fa70b99dd13ae5ad04c7c25af44c

> 
> 
> Diff: https://reviews.apache.org/r/64190/diff/2/
> 
> 
> Testing
> -------
> 
> `./gradlew test`
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message