aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 60942: Remove task level resource fields from thrift interface and db
Date Tue, 28 Nov 2017 01:00:29 GMT


> On Nov. 23, 2017, 12:46 p.m., Stephan Erb wrote:
> > RELEASE-NOTES.md
> > Lines 57 (patched)
> > <https://reviews.apache.org/r/60942/diff/10/?file=1901000#file1901000line57>
> >
> >     You will need to move this to 0.20.0. Also please state that you removed it.
The fields have been deprecated before.
> 
> Bill Farner wrote:
>     Note - this line is still in the 0.19.0 section in the latest diff, and needs to
be moved up to 0.20.0 as Stephan points out.
> 
> Nicolás Donatucci wrote:
>     In latest diff, revision 11, I'm seeing that line under the 0.20.0 section

Hmm my mistake, i now see that as well.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60942/#review191810
-----------------------------------------------------------


On Nov. 23, 2017, 12:52 p.m., Nicolás Donatucci wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60942/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2017, 12:52 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
> 
> 
> Bugs: AURORA-1707
>     https://issues.apache.org/jira/browse/AURORA-1707
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Removed task level resource fields from the DB and the thrift-API.
> To do this, a new DB migration was added. When upgrading, it just drops the task level
resource fields. When downgrading, it creates the fields again and populates them with information
from the task_resource table.
> 
> Issue Related: AURORA-1707
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md e622a8d38425a99c2965d64147fa0e680e5de517 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 2978f6d1218c24f93522ac3e0de9abd992e02430

>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java dd64a5b7fa94f4d98b80c24901072124c23ab953

>   src/main/python/apache/aurora/client/cli/diff_formatter.py 78717774aa3fbaf83a5fb850bc9f9f4a4038d70f

>   src/main/python/apache/aurora/client/cli/jobs.py cbae387a6eb8086652131a6617cb3a9c069d9c96

>   src/test/java/org/apache/aurora/scheduler/http/TestUtils.java 689482c9f6c49bcca781834566edeb975d2f3af2

>   src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java d1b5e40a44ff2d1af8de87ea6f2d1e542916d6fd

>   src/test/java/org/apache/aurora/scheduler/updater/UpdateAgentReserverImplTest.java
1bc2a778ad3f1543a055023f9ec3fe9e4a9523e3 
>   src/test/python/apache/aurora/client/cli/test_status.py b0b7f96d8148f0dd1f6f45d1c5c6f830cabcfd5d

>   src/test/python/apache/aurora/client/cli/util.py 476b8c2951f315db0b9983bb8fbed0d7efc155aa

>   src/test/python/apache/aurora/config/test_resources.py 25a20f0b702189744a26b85053db34c37ff5b03c

> 
> 
> Diff: https://reviews.apache.org/r/60942/diff/11/
> 
> 
> Testing
> -------
> 
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Created a new VM with a fresh Aurora 0.19.0, ran the tests. Then upgraded to patched
version and ran the tests again. Then downgraded to 0.19.0 and ran the tests again.
> 
> 
> Thanks,
> 
> Nicolás Donatucci
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message