aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <jordan....@gmail.com>
Subject Re: Review Request 63763: Fix flaky MesosCallbackHandlerTest
Date Mon, 13 Nov 2017 23:58:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63763/
-----------------------------------------------------------

(Updated Nov. 13, 2017, 11:58 p.m.)


Review request for Aurora and Bill Farner.


Changes
-------

Fix findbugs error


Repository: aurora


Description
-------

In the same vein as: https://reviews.apache.org/r/63760/

Fix a flaky test that uses `Thread.sleep` by injecting a fake Executor.


Diffs (updated)
-----

  src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 8f8b86dfb5d53439671ca59e6c42245b31fc6136



Diff: https://reviews.apache.org/r/63763/diff/2/

Changes: https://reviews.apache.org/r/63763/diff/1-2/


Testing
-------

`./gradlew test`


Thanks,

Jordan Ly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message