Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 97FFD200D2D for ; Fri, 27 Oct 2017 22:58:38 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 96660160BF2; Fri, 27 Oct 2017 20:58:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DCAF61609DD for ; Fri, 27 Oct 2017 22:58:37 +0200 (CEST) Received: (qmail 73178 invoked by uid 500); 27 Oct 2017 20:58:37 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 73167 invoked by uid 99); 27 Oct 2017 20:58:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Oct 2017 20:58:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0865E180807; Fri, 27 Oct 2017 20:58:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.437 X-Spam-Level: **** X-Spam-Status: No, score=4.437 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id JpsNhSFMMMiR; Fri, 27 Oct 2017 20:58:35 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 34B4E5F1E7; Fri, 27 Oct 2017 20:58:34 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D3A23E0A3A; Fri, 27 Oct 2017 20:58:33 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id F108DC4028F; Fri, 27 Oct 2017 20:58:31 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3050259986802893940==" MIME-Version: 1.0 Subject: Re: Review Request 63374: Revert to old Job Page tab names and add counts From: Kai Huang To: Reza Motamedi , Kai Huang Cc: David McLaughlin , Aurora Date: Fri, 27 Oct 2017 20:58:30 -0000 Message-ID: <20171027205830.34917.51760@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kai Huang X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63374/ X-Sender: Kai Huang X-ReviewBoard-ShipIt: 1 References: <20171027194843.63764.47117@reviews-vm2.apache.org> In-Reply-To: <20171027194843.63764.47117@reviews-vm2.apache.org> X-ReviewBoard-ShipIt-Only: 1 Reply-To: Kai Huang X-ReviewRequest-Repository: aurora archived-at: Fri, 27 Oct 2017 20:58:38 -0000 --===============3050259986802893940== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63374/#review189477 ----------------------------------------------------------- Ship it! Ship It! - Kai Huang On Oct. 27, 2017, 7:48 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63374/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 7:48 p.m.) > > > Review request for Aurora, Kai Huang and Reza Motamedi. > > > Repository: aurora > > > Description > ------- > > Changing the names of tabs causes unnecessary confusion. Revert to "active tasks/completed tasks" and add the instance count back to both. > > > Diffs > ----- > > ui/src/main/js/components/JobHistory.js 74f6fcb1117e80bcd5a033dad06ca00f9bc2ddfc > ui/src/main/js/components/JobStatus.js 84e335c91da7231eda30ae945dd669f80fb1cc38 > > > Diff: https://reviews.apache.org/r/63374/diff/1/ > > > Testing > ------- > > See screenshots. > > > File Attachments > ---------------- > > Screen Shot 2017-10-27 at 12.46.52 PM.png > https://reviews.apache.org/media/uploaded/files/2017/10/27/33061824-a52c-4b54-a14f-27793f5bc9ea__Screen_Shot_2017-10-27_at_12.46.52_PM.png > > > Thanks, > > David McLaughlin > > --===============3050259986802893940==--