Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DDF33200D3B for ; Fri, 27 Oct 2017 00:46:20 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DC7C6160BF3; Thu, 26 Oct 2017 22:46:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2EDD11609E5 for ; Fri, 27 Oct 2017 00:46:20 +0200 (CEST) Received: (qmail 56631 invoked by uid 500); 26 Oct 2017 22:46:19 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 56620 invoked by uid 99); 26 Oct 2017 22:46:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Oct 2017 22:46:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 44B5F18084E; Thu, 26 Oct 2017 22:46:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id d6GgICwARWt4; Thu, 26 Oct 2017 22:46:16 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 17B555F238; Thu, 26 Oct 2017 22:46:16 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6DC28E0A3A; Thu, 26 Oct 2017 22:46:15 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0B79EC41718; Thu, 26 Oct 2017 22:46:13 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2660642662865741904==" MIME-Version: 1.0 Subject: Re: Review Request 63344: Support updates with no desiredState on Job and Update pages From: Aurora ReviewBot To: Reza Motamedi , Kai Huang Cc: David McLaughlin , Aurora , Aurora ReviewBot Date: Thu, 26 Oct 2017 22:46:12 -0000 Message-ID: <20171026224612.51091.28513@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63344/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20171026220150.51092.20495@reviews-vm2.apache.org> In-Reply-To: <20171026220150.51092.20495@reviews-vm2.apache.org> Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Thu, 26 Oct 2017 22:46:21 -0000 --===============2660642662865741904== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63344/#review189369 ----------------------------------------------------------- Ship it! Master (875a312) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 26, 2017, 10:01 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63344/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2017, 10:01 p.m.) > > > Review request for Aurora, Kai Huang and Reza Motamedi. > > > Repository: aurora > > > Description > ------- > > When updates only delete instances, desiredState is null. > > > Diffs > ----- > > ui/src/main/js/components/UpdateConfig.js 89dea2512d6fed712c7f059006034cd3d1ffb0f7 > ui/src/main/js/utils/Update.js dee239312ecc6214d954336f1e57730f1e87802d > ui/src/main/js/utils/__tests__/Update-test.js 88fa5f7edb267246a1a0489eba414e9f7e84ee05 > > > Diff: https://reviews.apache.org/r/63344/diff/1/ > > > Testing > ------- > > ./gradlew ui:test > ./gradlew ui:lint > > Verified in Vagrant. > > > Thanks, > > David McLaughlin > > --===============2660642662865741904==--