Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8F4F1200D34 for ; Fri, 20 Oct 2017 01:23:58 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8DDD3160BEC; Thu, 19 Oct 2017 23:23:58 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D92781609EE for ; Fri, 20 Oct 2017 01:23:57 +0200 (CEST) Received: (qmail 35540 invoked by uid 500); 19 Oct 2017 23:23:57 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 35529 invoked by uid 99); 19 Oct 2017 23:23:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Oct 2017 23:23:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 10D8A1807F7; Thu, 19 Oct 2017 23:23:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id dfLyHSjIpafO; Thu, 19 Oct 2017 23:23:54 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id F0EC85FC9B; Thu, 19 Oct 2017 23:23:53 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 50EA3E00C9; Thu, 19 Oct 2017 23:23:53 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3E364C410F6; Thu, 19 Oct 2017 23:23:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3785200619168517344==" MIME-Version: 1.0 Subject: Re: Review Request 63157: Provide a formal way to disable offer declining From: Aurora ReviewBot To: Jordan Ly Cc: Bill Farner , Aurora ReviewBot , Aurora Date: Thu, 19 Oct 2017 23:23:53 -0000 Message-ID: <20171019232353.56752.77212@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63157/ X-Sender: Aurora ReviewBot X-ReviewBoard-ShipIt: 1 References: <20171019224822.56753.5880@reviews-vm2.apache.org> In-Reply-To: <20171019224822.56753.5880@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/offers/Deferment.java Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Thu, 19 Oct 2017 23:23:58 -0000 --===============3785200619168517344== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63157/#review188794 ----------------------------------------------------------- Ship it! Master (5397013) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 19, 2017, 3:48 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63157/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2017, 3:48 p.m.) > > > Review request for Aurora and Jordan Ly. > > > Repository: aurora > > > Description > ------- > > Increasing the offer hold time to effectively disable offer declines is a trap, as the queue of asynchronous declines will grow without bound. This introduces a command line argument to explicitly disable declining. > > > Diffs > ----- > > RELEASE-NOTES.md f4cc4163972ce516fd07747d004e0b8bfe5b2bd7 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 7d3766829161457b1b3ba50bce128047d10b2c58 > src/main/java/org/apache/aurora/scheduler/offers/Deferment.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java e8334310a2a46a0ccb09ee6e4122c515892d3996 > src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java 4c6fd546a450917b7542329b020f42ef6379f3b7 > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java ab98addf6b63c3e4b97374c3d5adcd79ceec78c0 > src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 8f4f63c73c2c2133c7beaf22e1abccfd966f542c > src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 815a7e8200ad7b25080556bddd54d407a74678cc > > > Diff: https://reviews.apache.org/r/63157/diff/3/ > > > Testing > ------- > > > Thanks, > > Bill Farner > > --===============3785200619168517344==--