Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2D511200D1E for ; Wed, 18 Oct 2017 23:40:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2BE20160BEA; Wed, 18 Oct 2017 21:40:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7188A1609DE for ; Wed, 18 Oct 2017 23:40:48 +0200 (CEST) Received: (qmail 2302 invoked by uid 500); 18 Oct 2017 21:40:42 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 1607 invoked by uid 99); 18 Oct 2017 21:40:42 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2017 21:40:42 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 5398F18070C; Wed, 18 Oct 2017 21:40:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id ifKpd5vK4_1g; Wed, 18 Oct 2017 21:40:40 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 66B4B5F121; Wed, 18 Oct 2017 21:40:39 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 56073E06BB; Wed, 18 Oct 2017 21:40:38 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 3A879C404AC; Wed, 18 Oct 2017 21:40:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7755288827269772157==" MIME-Version: 1.0 Subject: Re: Review Request 63125: Add cron configuration to Job Page From: David McLaughlin To: Santhosh Kumar Shanmugham , Kai Huang Cc: Aurora ReviewBot , Aurora , David McLaughlin Date: Wed, 18 Oct 2017 21:40:38 -0000 Message-ID: <20171018214038.63799.34554@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David McLaughlin X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63125/ X-Sender: David McLaughlin References: <20171018211746.63799.23697@reviews-vm2.apache.org> In-Reply-To: <20171018211746.63799.23697@reviews-vm2.apache.org> Reply-To: David McLaughlin X-ReviewRequest-Repository: aurora archived-at: Wed, 18 Oct 2017 21:40:49 -0000 --===============7755288827269772157== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63125/ ----------------------------------------------------------- (Updated Oct. 18, 2017, 9:40 p.m.) Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. Changes ------- lint fixes. Repository: aurora Description ------- Adds cron configuration to Job Page. Diffs (updated) ----- ui/.eslintrc f7ac075d8b0e65a2541bbee1bfd9e552f4eda95b ui/src/main/js/components/JobConfig.js 275f46a88701f819007918faa3ad5a258880b308 ui/src/main/js/components/TaskConfigSummary.js 5c00d1e0a74a93d23b7f0e007efa6990befa6ffe ui/src/main/js/components/__tests__/JobConfig-test.js 59541d9afb22de036a0076360a0e8b915548a98b ui/src/main/js/pages/Job.js 6a9bd7e5e7a2d24df0a8e5b07830485ffe718d3d ui/src/main/js/pages/__tests__/Job-test.js 09dd54ec0a49f425c7de18e9bb1a1b3e7b98a624 ui/src/main/js/utils/Thrift.js 4336bd1d62f145b38e667604c810436910e90b38 ui/src/main/sass/components/_job-page.scss cd038322ab12f5851d2e506887eddac503c62586 ui/test-setup.js a86a89a0a27b335b02cf514335e6ddd8f30b23c1 Diff: https://reviews.apache.org/r/63125/diff/2/ Changes: https://reviews.apache.org/r/63125/diff/1-2/ Testing ------- ./gradlew ui:lint ./gradlew ui:test See screenshot. File Attachments ---------------- Screen Shot 2017-10-18 at 2.04.59 PM.png https://reviews.apache.org/media/uploaded/files/2017/10/18/c114ecb7-7b63-4bc4-9c44-e2b2c5f479b2__Screen_Shot_2017-10-18_at_2.04.59_PM.png Thanks, David McLaughlin --===============7755288827269772157==--