Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.apache.org
Content-Type: multipart/alternative;
 boundary="===============8204111348438384947=="
MIME-Version: 1.0
Subject: Re: Review Request 63125: Add cron configuration to Job Page
From: Aurora ReviewBot <wfarner@apache.org>
To: Santhosh Kumar Shanmugham <santhoshkumar.s@gmail.com>,
 Kai Huang <texasred2013@hotmail.com>
Cc: Aurora ReviewBot <wfarner@apache.org>, Aurora <reviews@aurora.apache.org>,
 David McLaughlin <david@dmclaughlin.com>
Date: Wed, 18 Oct 2017 21:24:34 -0000
Message-ID: <20171018212434.63799.20096@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: Aurora ReviewBot <noreply@reviews.apache.org>
References: <20171018211746.63799.23697@reviews-vm2.apache.org>
In-Reply-To: <20171018211746.63799.23697@reviews-vm2.apache.org>
Reply-To: Aurora ReviewBot <wfarner@apache.org>
archived-at: Wed, 18 Oct 2017 21:24:42 -0000

--===============8204111348438384947==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63125/#review188581
-----------------------------------------------------------


Master (f820b27) is red with this patch.
  ./build-support/jenkins/build.sh

  20 errors, 0 warnings potentially fixable with the `--fix` option.


npm ERR! Linux 4.4.0-89-generic
npm ERR! argv "/home/jenkins/jenkins-slave/workspace/AuroraBot/ui/.gradle/nodejs/node-v6.9.1-linux-x64/bin/node" "/home/jenkins/jenkins-slave/workspace/AuroraBot/ui/.gradle/nodejs/node-v6.9.1-linux-x64/bin/npm" "run" "lint"
npm ERR! node v6.9.1
npm ERR! npm  v3.10.8
npm ERR! code ELIFECYCLE
npm ERR! apache-aurora@1.0.0 lint: `eslint src/main/js --ext .js`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the apache-aurora@1.0.0 lint script 'eslint src/main/js --ext .js'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the apache-aurora package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     eslint src/main/js --ext .js
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs apache-aurora
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls apache-aurora
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /home/jenkins/jenkins-slave/workspace/AuroraBot/ui/npm-debug.log
:ui:lint FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ui:lint'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/ui/.gradle/nodejs/node-v6.9.1-linux-x64/bin/npm'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 5m 39s
58 actionable tasks: 47 executed, 11 up-to-date


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 18, 2017, 9:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63125/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 9:17 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds cron configuration to Job Page.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobConfig.js 275f46a88701f819007918faa3ad5a258880b308 
>   ui/src/main/js/components/TaskConfigSummary.js 5c00d1e0a74a93d23b7f0e007efa6990befa6ffe 
>   ui/src/main/js/components/__tests__/JobConfig-test.js 59541d9afb22de036a0076360a0e8b915548a98b 
>   ui/src/main/js/pages/Job.js 6a9bd7e5e7a2d24df0a8e5b07830485ffe718d3d 
>   ui/src/main/js/pages/__tests__/Job-test.js 09dd54ec0a49f425c7de18e9bb1a1b3e7b98a624 
>   ui/src/main/js/utils/Thrift.js 4336bd1d62f145b38e667604c810436910e90b38 
>   ui/src/main/sass/components/_job-page.scss cd038322ab12f5851d2e506887eddac503c62586 
>   ui/test-setup.js a86a89a0a27b335b02cf514335e6ddd8f30b23c1 
> 
> 
> Diff: https://reviews.apache.org/r/63125/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> See screenshot.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-18 at 2.04.59 PM.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/18/c114ecb7-7b63-4bc4-9c44-e2b2c5f479b2__Screen_Shot_2017-10-18_at_2.04.59_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


--===============8204111348438384947==--