Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 29A4C200D2F for ; Wed, 18 Oct 2017 05:13:48 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2809D1609EC; Wed, 18 Oct 2017 03:13:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6EFC11609EB for ; Wed, 18 Oct 2017 05:13:47 +0200 (CEST) Received: (qmail 333 invoked by uid 500); 18 Oct 2017 03:13:46 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 321 invoked by uid 99); 18 Oct 2017 03:13:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2017 03:13:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 52E86180414; Wed, 18 Oct 2017 03:13:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.25 X-Spam-Level: *** X-Spam-Status: No, score=3.25 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Av16q0lzOD4o; Wed, 18 Oct 2017 03:13:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EDCB65F2AD; Wed, 18 Oct 2017 03:13:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6CAE5E00B3; Wed, 18 Oct 2017 03:13:43 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 70958C4111E; Wed, 18 Oct 2017 03:13:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8290652144499007511==" MIME-Version: 1.0 Subject: Review Request 63098: Clean up Job Page CSS From: David McLaughlin To: Santhosh Kumar Shanmugham , Kai Huang Cc: Aurora , David McLaughlin Date: Wed, 18 Oct 2017 03:13:40 -0000 Message-ID: <20171018031340.5693.80979@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: David McLaughlin X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/63098/ X-Sender: David McLaughlin Reply-To: David McLaughlin X-ReviewRequest-Repository: aurora archived-at: Wed, 18 Oct 2017 03:13:48 -0000 --===============8290652144499007511== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63098/ ----------------------------------------------------------- Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham. Repository: aurora Description ------- Clean up Job Page CSS. * Make update list smaller (was too dominant on the page). * Show update progress/size of history. * Tidy up whitespace. * Move expander to end of task list item. * Wrap the main job overview loading element in a panel group to prevent jarring page change as content loads. Diffs ----- ui/src/main/js/components/TaskList.js 5a61de8fc46cc729906eb756c54c208320d34da7 ui/src/main/js/components/UpdateList.js 2df28394713d31da7d60b6b32028c16613bec3a0 ui/src/main/js/pages/Job.js 5f92ad0b801c047f6c056623069438a5aa781c02 ui/src/main/js/pages/__tests__/Job-test.js 2b126b65bb09c40a528f87148942615dd035e36d ui/src/main/sass/components/_task-list.scss a6e2f0a1994134381c6d16b05209771ab2b09988 ui/src/main/sass/components/_update-list.scss 83a1f5a07291ea3aaabb8145877f5d7f8d8f433e Diff: https://reviews.apache.org/r/63098/diff/1/ Testing ------- ./gradlew ui:lint ./gradlew ui:test See screenshots. File Attachments ---------------- Tighter task list item. https://reviews.apache.org/media/uploaded/files/2017/10/18/8effbff4-5b1a-4883-857e-b6107ff25c6c__Screen_Shot_2017-10-17_at_8.06.09_PM.png Job Update List https://reviews.apache.org/media/uploaded/files/2017/10/18/9b237777-1d3b-4eb4-94c3-cb0b332dfd95__Screen_Shot_2017-10-17_at_8.06.16_PM.png Thanks, David McLaughlin --===============8290652144499007511==--