Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7E5C4200D21 for ; Mon, 16 Oct 2017 20:26:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 7D0CB1609EF; Mon, 16 Oct 2017 18:26:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C16561609E3 for ; Mon, 16 Oct 2017 20:26:39 +0200 (CEST) Received: (qmail 70704 invoked by uid 500); 16 Oct 2017 18:26:39 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 70693 invoked by uid 99); 16 Oct 2017 18:26:38 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Oct 2017 18:26:38 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E88931808A7; Mon, 16 Oct 2017 18:26:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 4.687 X-Spam-Level: **** X-Spam-Status: No, score=4.687 tagged_above=-999 required=6.31 tests=[FORGED_HOTMAIL_RCVD2=1.187, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 2Jg8VCYTmFsk; Mon, 16 Oct 2017 18:26:36 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7D7EE5F6CD; Mon, 16 Oct 2017 18:26:36 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 277CBE041C; Mon, 16 Oct 2017 18:26:36 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 0B739C410F7; Mon, 16 Oct 2017 18:26:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0669350448001487668==" MIME-Version: 1.0 Subject: Re: Review Request 62958: Add URL handling for tab switching on Job page From: Kai Huang To: Santhosh Kumar Shanmugham , Reza Motamedi , Kai Huang Cc: Aurora , David McLaughlin Date: Mon, 16 Oct 2017 18:26:36 -0000 Message-ID: <20171016182636.6827.82699@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Kai Huang X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62958/ X-Sender: Kai Huang X-ReviewBoard-ShipIt: 1 References: <20171013001044.36034.3821@reviews-vm2.apache.org> In-Reply-To: <20171013001044.36034.3821@reviews-vm2.apache.org> Reply-To: Kai Huang X-ReviewRequest-Repository: aurora archived-at: Mon, 16 Oct 2017 18:26:40 -0000 --===============0669350448001487668== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62958/#review188181 ----------------------------------------------------------- Ship it! LGTM - Kai Huang On Oct. 13, 2017, 12:10 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62958/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2017, 12:10 a.m.) > > > Review request for Aurora, Kai Huang, Reza Motamedi, and Santhosh Kumar Shanmugham. > > > Repository: aurora > > > Description > ------- > > This maintains the existing UI functionality where clicking on tabs updates the browser location, to create shareable URLs to tab views. > > > Diffs > ----- > > ui/package.json cde8d106346d9ac498cfee9b5291ebc637fc6a2a > ui/src/main/js/components/Tabs.js 43b1950b11b80dc3017730801992341bc527c39c > ui/src/main/js/components/__tests__/Tabs-test.js e028c2dd86739ed9762aa1d0be5c609d5487e06e > ui/src/main/js/pages/Job.js fc400f7442a1f8a5f0ebfe366dfe40ef40e7108e > ui/src/main/js/pages/__tests__/Job-test.js 4cc76b8731d71ceca87a5d1e259360b2af8feba0 > > > Diff: https://reviews.apache.org/r/62958/diff/1/ > > > Testing > ------- > > ./gradlew ui:lint > ./gradlew ui:test > > Unfortunately the testing here is only on one side (restoring the URL state). I cannot simulate the change events from the unit tests because of limitations with shallow rendering. When I figure out how to add integration tests that work with React Router, I'll add coverage. > > > Thanks, > > David McLaughlin > > --===============0669350448001487668==--