Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 427E0200D1B for ; Thu, 12 Oct 2017 20:25:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 411FF1609E8; Thu, 12 Oct 2017 18:25:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5F0241609E4 for ; Thu, 12 Oct 2017 20:25:48 +0200 (CEST) Received: (qmail 16552 invoked by uid 500); 12 Oct 2017 18:25:47 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 16541 invoked by uid 99); 12 Oct 2017 18:25:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Oct 2017 18:25:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 800671A157C; Thu, 12 Oct 2017 18:25:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.249 X-Spam-Level: *** X-Spam-Status: No, score=3.249 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, KAM_LOTSOFHASH=0.25, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id r1z6C8QN0b4N; Thu, 12 Oct 2017 18:25:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CDD8661105; Thu, 12 Oct 2017 18:25:43 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5C582E05C1; Thu, 12 Oct 2017 18:25:43 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id C0BCEC404AC; Thu, 12 Oct 2017 18:25:42 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6255397505769267230==" MIME-Version: 1.0 Subject: Re: Review Request 62652: Remove legacy commons ZK code From: Aurora ReviewBot To: David McLaughlin , John Sirois Cc: Bill Farner , Aurora , Aurora ReviewBot Date: Thu, 12 Oct 2017 18:25:41 -0000 Message-ID: <20171012182541.48451.80512@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Aurora ReviewBot X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62652/ X-Sender: Aurora ReviewBot References: <20171008172945.24242.62748@reviews-vm2.apache.org> In-Reply-To: <20171008172945.24242.62748@reviews-vm2.apache.org> X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/Encoding.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java X-ReviewBoard-Diff-For: commons/src/test/java/org/apache/aurora/common/zookeeper/EncodingTest.java X-ReviewBoard-Diff-For: commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitorTest.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/discovery/CommonsDiscoveryModuleTest.java X-ReviewBoard-Diff-For: src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java X-ReviewBoard-Diff-For: commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor.java X-ReviewBoard-Diff-For: commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java X-ReviewBoard-Diff-For: commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java X-ReviewBoard-Diff-For: commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java X-ReviewBoard-Diff-For: commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java X-ReviewBoard-Diff-For: src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java X-ReviewBoard-Diff-For: commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java Reply-To: Aurora ReviewBot X-ReviewRequest-Repository: aurora archived-at: Thu, 12 Oct 2017 18:25:49 -0000 --===============6255397505769267230== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62652/#review187827 ----------------------------------------------------------- Master (519e3df) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Oct. 8, 2017, 5:29 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62652/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2017, 5:29 p.m.) > > > Review request for Aurora, David McLaughlin and John Sirois. > > > Repository: aurora > > > Description > ------- > > This is the result removing the deprecated `-zk_use_curator` arg in `FlaggedZooKeeperConfig.java`, and following the trail of unused code. Thanks for the clean separation, John! > > > Diffs > ----- > > RELEASE-NOTES.md c58e68080beb1740d92639601ef7cc29c63be37e > commons/src/main/java/org/apache/aurora/common/net/pool/DynamicHostSet.java df469efac2d994517d9b931cb2c1582e09d0cab7 > commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java 75c1b1493eb178ea035a0e60f20df694626c7f50 > commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java 98b5ee4690482683526f2e8ce4c965ed052b0232 > commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java 2720dd13a3cc5e39f7242664fbe98f00fb75eb08 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java aeea02d81faa3c8841edb9002498515dd0b52242 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java ace4980d3e15dc830fea48b83f0688347c71d900 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java 01a54a5718388df7f02992388653d7b049422787 > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonServiceImpl.java d9978a926e05e4303a168c7c51ee226a7dc94336 > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java ce243fb44266b741ff3f14eb5438ff38cf46133f > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 2ada2646da7bdc3276803336cc638e23b9e61d26 > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/BaseZooKeeperClientTest.java ba09279be9d8bfde79b7610a184bb472ab0396b5 > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 29204cda66343c5b3c80d167eccd36abfb6ee641 > commons/src/test/java/org/apache/aurora/common/zookeeper/CandidateImplTest.java 9c0cebe888d966fd64d17778c354136df0e13c7e > commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java 97a42d1bd6c60598d7936a2c065e163c1505ef3d > commons/src/test/java/org/apache/aurora/common/zookeeper/JsonCodecTest.java 2166123e9acd701e55e10b450a9eb89054c7afdd > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java f0c0cb4491c7b5c34103864ee244a27db3972a94 > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java 0e6719154ee5195111db51d323fa35c3bc56ec2b > commons/src/test/java/org/apache/aurora/common/zookeeper/SingletonServiceImplTest.java 5f6cdd83ca6c6338f8c7a0a3c93b960c036cb05e > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java 5eee235162e938ecdfdb7d3c4d31d848a34a648b > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java 9e482a6162abe5f9864d0ca0094cd97dc8036496 > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceDiscoveryModule.java 339f63b94e996e13514e6a6dcd7bbeef3a0f09f8 > src/main/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitor.java 9161455c3101fb0d83633883a67ce0ffe22fcdf8 > src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java ea167a89a95f0f35d53a34631ae44e0a911a6817 > src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java c2e8ce24bbb029a1c52cbdabce19a98029bc33f2 > src/main/java/org/apache/aurora/scheduler/discovery/ServiceDiscoveryModule.java 917a5679699581fb345d51d2837f372411d4beda > src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java f6faca56cbfceeb9e1226c0e8feec13c7c772d94 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java a363e70176881518653d0774e9d0c4be0f7f6d78 > src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 9b4f2ad15ab5b61d4cccfad38ba48f17e7853425 > src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java 0f2121ef1453b41286f9713d5ce89a26d1cb1b4f > src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java 226b0686f91539decd7d421a28d431209bcec790 > src/test/java/org/apache/aurora/scheduler/discovery/CommonsDiscoveryModuleTest.java 7a4c4dd932fa0a69f22bcbb5cba7750bba52e16d > src/test/java/org/apache/aurora/scheduler/discovery/CommonsServiceGroupMonitorTest.java 42a2224839f00e6938100fc315874c531cb37096 > src/test/java/org/apache/aurora/scheduler/discovery/CuratorDiscoveryModuleTest.java f1a02e4becc5865e72aaf96334c53cb9c395d09a > src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java a065505134c1ad30ba9f4d4cd829355b2acc9a13 > src/test/java/org/apache/aurora/scheduler/http/LeaderHealthTest.java d21a38ed66253eb7a2ceefaf6c0ec1b788036552 > > > Diff: https://reviews.apache.org/r/62652/diff/3/ > > > Testing > ------- > > `./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh` > > > Thanks, > > Bill Farner > > --===============6255397505769267230==--