aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 63406: Condense whitespace of navigation and breadcrumb, reduce impact of quota widget
Date Mon, 30 Oct 2017 15:56:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63406/#review189601
-----------------------------------------------------------


Ship it!




Master (3fe5d59) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 30, 2017, 3:32 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63406/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 3:32 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Condense whitespace (height reduction of ~50%) of navigation and breadcrumb to better
support smaller screens than mine. 
> 
> Reduce visual impact of quota widget on job list page. Tighten up items in task list
to fit more per page.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/pages/Jobs.js d3bef8c9e8d14fa5101b3103f102659cca7f4166 
>   ui/src/main/sass/components/_base.scss fadd0d24539dcacc8bd2b7bedd3a5a03cffc78df 
>   ui/src/main/sass/components/_breadcrumb.scss 67c0c98c2087ff5f926b746e570ecfac85e6bf5a

>   ui/src/main/sass/components/_job-list-page.scss 4783aa400d679eb302892a7bec7ae1382df9df8b

>   ui/src/main/sass/components/_navigation.scss 46cb54174e5e03b134bf3727c91209967af1028c

>   ui/src/main/sass/components/_task-list.scss 3c7221942353b592d36432bbe6a4c09ab7ce272f

> 
> 
> Diff: https://reviews.apache.org/r/63406/diff/1/
> 
> 
> Testing
> -------
> 
> Cosmetic changes only. See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> whitespace-master.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/30/04261124-6e54-43cd-87fc-968f85869fda__whitespace-master.png
> whitespace-patch.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/30/6a929d59-c650-4844-bd1f-6eef80196111__whitespace-patch.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message