aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <jordan....@gmail.com>
Subject Re: Review Request 63316: MesosCallbackHandler uses separate eventbus for registered call
Date Fri, 27 Oct 2017 21:27:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63316/
-----------------------------------------------------------

(Updated Oct. 27, 2017, 9:27 p.m.)


Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner.


Changes
-------

Remove unused import


Bugs: AURORA-1953
    https://issues.apache.org/jira/browse/AURORA-1953


Repository: aurora


Description
-------

We should have `registered` use its own eventbus so it does not get blocked by other calls.

See attached ticket for details.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 382181939d292ee00ea2071daec66aa0669609e4

  src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java 6758f8c3d6fbfb9f3e6f4d05d27a423388d0bdab

  src/main/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandler.java 68d19ec53b3bb5ee02934254e8f9c82ae720c6ed

  src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java b54e1f3d427b8e99fb022536004014c3fee498d0

  src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java f656b271c0f3270f162c205923b300d8fe1ec0b7

  src/test/java/org/apache/aurora/scheduler/mesos/MesosCallbackHandlerTest.java 4d1a6761b8cd761d96cbfb35b0944eb524bd654f



Diff: https://reviews.apache.org/r/63316/diff/7/

Changes: https://reviews.apache.org/r/63316/diff/6-7/


Testing
-------

`./gradlew test`


Thanks,

Jordan Ly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message