aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kai Huang <texasred2...@hotmail.com>
Subject Re: Review Request 63374: Revert to old Job Page tab names and add counts
Date Fri, 27 Oct 2017 20:58:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63374/#review189477
-----------------------------------------------------------


Ship it!




Ship It!

- Kai Huang


On Oct. 27, 2017, 7:48 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63374/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2017, 7:48 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Changing the names of tabs causes unnecessary confusion. Revert to "active tasks/completed
tasks" and add the instance count back to both.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobHistory.js 74f6fcb1117e80bcd5a033dad06ca00f9bc2ddfc 
>   ui/src/main/js/components/JobStatus.js 84e335c91da7231eda30ae945dd669f80fb1cc38 
> 
> 
> Diff: https://reviews.apache.org/r/63374/diff/1/
> 
> 
> Testing
> -------
> 
> See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-27 at 12.46.52 PM.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/27/33061824-a52c-4b54-a14f-27793f5bc9ea__Screen_Shot_2017-10-27_at_12.46.52_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message