aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 63344: Support updates with no desiredState on Job and Update pages
Date Thu, 26 Oct 2017 22:46:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63344/#review189369
-----------------------------------------------------------


Ship it!




Master (875a312) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 26, 2017, 10:01 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63344/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2017, 10:01 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> When updates only delete instances, desiredState is null.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/UpdateConfig.js 89dea2512d6fed712c7f059006034cd3d1ffb0f7

>   ui/src/main/js/utils/Update.js dee239312ecc6214d954336f1e57730f1e87802d 
>   ui/src/main/js/utils/__tests__/Update-test.js 88fa5f7edb267246a1a0489eba414e9f7e84ee05

> 
> 
> Diff: https://reviews.apache.org/r/63344/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> Verified in Vagrant.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message