aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <>
Subject Re: Review Request 63316: Directly call 'registered' in SchedulerLifecycle as opposed to having it be a pubsub event
Date Thu, 26 Oct 2017 03:14:11 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 26, 2017, 3:14 a.m.)

Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner.


Inject a listener instead of injecting a bunch of components.

Repository: aurora


Directly call 'registered' in SchedulerLifecycle as opposed to having it be a pubsub event.

It is currently possible for the scheduler to register with Mesos, but have the pubsub event
stating registration was successful get drowned out by other events (i.e. status updates).
This can cause the scheduler to think that registration was not successful and transition
to a DEAD state. This edge-case can cause the scheduler to flap, since when it comes back
up it will still get the same flood of status updates and potentially fail to register again.

Diffs (updated)

  src/main/java/org/apache/aurora/scheduler/ PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/ aa09aff5fc65352111223abfc2425e8e066b9383

  src/main/java/org/apache/aurora/scheduler/ 382181939d292ee00ea2071daec66aa0669609e4

  src/main/java/org/apache/aurora/scheduler/events/ 73fcdd0a7b3476a26c5383edbfef522aa65f4435

  src/main/java/org/apache/aurora/scheduler/mesos/ 68d19ec53b3bb5ee02934254e8f9c82ae720c6ed

  src/main/java/org/apache/aurora/scheduler/mesos/ b54e1f3d427b8e99fb022536004014c3fee498d0

  src/main/java/org/apache/aurora/scheduler/mesos/ 46090642bf21819fccd232d1202a14f5534310a8

  src/test/java/org/apache/aurora/scheduler/ edd738030edf3c00e96c57dffbde4cf6b20dde41

  src/test/java/org/apache/aurora/scheduler/mesos/ 4d1a6761b8cd761d96cbfb35b0944eb524bd654f





`./gradlew test`


Jordan Ly

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message