aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kai Huang <texasred2...@hotmail.com>
Subject Re: Review Request 63281: Clean up TaskList component layout.
Date Wed, 25 Oct 2017 17:10:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63281/#review189207
-----------------------------------------------------------


Ship it!




LGTM


ui/src/main/js/components/TaskListItemActions.js
Lines 3 (patched)
<https://reviews.apache.org/r/63281/#comment266175>

    s/TaskListItemActioins/TaskListItemHost/ ?


- Kai Huang


On Oct. 24, 2017, 11:32 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63281/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2017, 11:32 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Clean up TaskList component layout by separating out some of the components (to help
with extensibility).
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/TaskList.js 4a4b8d365737b002acbe47c2d9b0253c5ce4f2ed 
>   ui/src/main/js/components/TaskListItem.js PRE-CREATION 
>   ui/src/main/js/components/TaskListItemActions.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/TaskList-test.js c222b61de65c6333e9689123302206802871eb90

>   ui/src/main/js/components/__tests__/TaskListItem-test.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63281/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message