aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 63262: Add a package.json file in the plugin directory to allow custom dependencies
Date Tue, 24 Oct 2017 22:18:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63262/#review189103
-----------------------------------------------------------


Ship it!




Master (71bb41c) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 24, 2017, 9:46 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63262/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2017, 9:46 p.m.)
> 
> 
> Review request for Aurora and Reza Motamedi.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Problem: if you're using the plugin mechanism of the new UI, you cannot add your own
custom dependencies without a fork of the package.json file. This adds a package.json file
into the plugin diretory that is used to install dependencies into the main node_modules directory.
With this separate package.json file, we remove the burden of upstream merge conflicts.
> 
> 
> Diffs
> -----
> 
>   build.gradle d110d4ab6b53bce4d76376b36ac35a1f1972cdda 
>   ui/plugin/package.json PRE-CREATION 
>   ui/webpack.config.js 60e611c35fbc0bce07db04536da07378ad9d145c 
> 
> 
> Diff: https://reviews.apache.org/r/63262/diff/1/
> 
> 
> Testing
> -------
> 
> I verified this in my local Vagrant by adding some d3 dependencies into package.json
and noting they were installed when I ran ./gradlew ui:webpack
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message