aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 63260: Fix alignment of text on JobList
Date Tue, 24 Oct 2017 21:58:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63260/#review189098
-----------------------------------------------------------


Ship it!




Ship It!

- Santhosh Kumar Shanmugham


On Oct. 24, 2017, 1:44 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63260/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2017, 1:44 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> They mix of upper and lowercase letters is making the centered text look off (when the
box model is actually doing the right thing). To compensate, manually raise the job name text.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/sass/components/_job-list-page.scss 4738de849cf13ced71b2ace3cae7c8a9a8342698

> 
> 
> Diff: https://reviews.apache.org/r/63260/diff/1/
> 
> 
> Testing
> -------
> 
> In Vagrant (see screenshots).
> 
> 
> File Attachments
> ----------------
> 
> before
>   https://reviews.apache.org/media/uploaded/files/2017/10/24/7f0997c4-2cf6-42fc-b0d9-07bd43a61767__Screen_Shot_2017-10-24_at_1.41.50_PM.png
> after
>   https://reviews.apache.org/media/uploaded/files/2017/10/24/7b5ee436-5f72-4a61-9c99-cd60d1a08efc__Screen_Shot_2017-10-24_at_1.42.02_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message