aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 63188: Add sorting and filtering controls for TaskList
Date Mon, 23 Oct 2017 17:54:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63188/#review188967
-----------------------------------------------------------


Ship it!




Master (ec64011) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 23, 2017, 5:34 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63188/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2017, 5:34 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add filtering for the task lists on the Job page. Allows the user to filter by status
(and at the same time, see the different statuses that their tasks are in across multiple
pages), to search by host, instanceId or status and to also control whether to sort by most
recent event or by instance id.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobHistory.js 9f00a7bfd1c7a3d7b7d0b08f9a5f6d9b82d33b55 
>   ui/src/main/js/components/TaskList.js dd34c62e25f63f9b9b43076a3d5f0868d0601ee2 
>   ui/src/main/js/components/__tests__/JobHistory-test.js 13f7ecc958fa06949c1e9e4706f010a3cafb2fa7

>   ui/src/main/js/components/__tests__/TaskList-test.js ae74ff416b836d3d3fe2c9982ff490e637b05419

>   ui/src/main/js/utils/Common.js 603a11b325acefb96ebdb100ba6798d33b5f037d 
>   ui/src/main/js/utils/__tests__/Common-test.js PRE-CREATION 
>   ui/src/main/sass/components/_task-list.scss 42b9cac9b2d45e172da65f8c20e307bb6ad8e4de

> 
> 
> Diff: https://reviews.apache.org/r/63188/diff/3/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> No status filter when all tasks in same state
>   https://reviews.apache.org/media/uploaded/files/2017/10/20/737b6676-7729-4e12-8c20-85004f989cb3__Screen_Shot_2017-10-20_at_2.16.32_PM.png
> Task status filter
>   https://reviews.apache.org/media/uploaded/files/2017/10/20/1979f4ff-d6a2-424b-b1df-de91a8165dae__Screen_Shot_2017-10-20_at_2.16.43_PM.png
> No search when only one page
>   https://reviews.apache.org/media/uploaded/files/2017/10/20/c1e280d7-6277-4f1f-b104-abf45c339840__Screen_Shot_2017-10-20_at_2.46.37_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message