aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 63204: Update to guava 23.2
Date Sun, 22 Oct 2017 18:06:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63204/#review188910
-----------------------------------------------------------


Ship it!




Master (dbe9a52) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 22, 2017, 10:43 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63204/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2017, 10:43 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Notable changes along the way:
> - [21](https://github.com/google/guava/wiki/Release21): better compatibility with jdk
8 functional types, should make it easier for us to gradually transition 
> - `android` and `jre` releases are now provided, hence the `-jre` version modifier
> 
> This required a curator [bump](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314425&version=12338714)
to address a guava version conflict.  This has the upside of avoiding future guava conflicts
with curator, as they now [shade guava classes](https://cwiki.apache.org/confluence/display/CURATOR/TN13).
> 
> 
> Diffs
> -----
> 
>   build.gradle fbe5bb1e2683a2328ebd6334f35ce59719dddb15 
>   src/main/java/org/apache/aurora/scheduler/TierModule.java 4244103dccdf235e439c8478b12d3a6b873651a0

>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 8e13341d784f9eaa0c0829c85b884c61e6ff0fff

>   src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
4a0379814df76703efa4182241a9863047612e96 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 6fdf31d6ed430f3dc0a0117442fc8b532aa40230

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 8e3c1deb7805b2d2e9775dde20ab525ed27087b5

>   src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 692adebd97cba5d6f953143c5e4bacc207aace28

>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 6e77857fcf209d3fe70fbd30cfd8484ea0414ee2

>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java a16058f32306332f3d37aae1e25dece86c3fa8cc

>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 1a5cd010be03e25b2a31dff7c43cd0f2f95d7b61

>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 86bcab21ecab338d89d9397be9f215d8829f6935

>   src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java a561d0909cef27b24334165f0d40cfd734b2c9a6

>   src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 09f443bca90f154b547d28ca5fd5be08177fdf99

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java c5193238db5cb65373f7cb69e6b38b2e3b051dae

> 
> 
> Diff: https://reviews.apache.org/r/63204/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message