aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Farner <wfar...@apache.org>
Subject Re: Review Request 63176: Add Cache-Control header to static assets, to allow for cache expiration
Date Fri, 20 Oct 2017 05:01:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63176/#review188809
-----------------------------------------------------------



I don't feel strongly, but `DefaultServlet` can also send an etag header by instead setting
`"etags", "true"`.

- Bill Farner


On Oct. 19, 2017, 9:46 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63176/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 9:46 p.m.)
> 
> 
> Review request for Aurora, Jordan Ly and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The Scheduler currently returns last-modified headers for static assets, the idea is
that the client (the browser) will send HTTP GET requests with an If-Modified-Since header
and the Jetty Servlet will intercept them and return 304s, saving everyone some download time.

> 
> But without a max-age or Expires header set, the browsers are just caching the assets
indefinitely - causing real pains when you want to propagate UI changes to users. This sets
the max-age of the browser cache to an hour.
> 
> I'll have a follow-up review to disable caching of resources completely when in Vagrant
- because that gets annoying when developing the UI.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 93cd20adc28ed700719e472bb2331137a93d1d9d

> 
> 
> Diff: https://reviews.apache.org/r/63176/diff/1/
> 
> 
> Testing
> -------
> 
> I verified the caching behavior in Chrome with my local Vagrant.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message