aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 63169: Add an example of using the UI plugin mechanism
Date Thu, 19 Oct 2017 21:19:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63169/#review188760
-----------------------------------------------------------


Ship it!




Probably rename the `plugin/Home.js` as `plugin/Example.js`.

- Santhosh Kumar Shanmugham


On Oct. 19, 2017, 2:05 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63169/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 2:05 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an example of using the UI plugin mechanism
> 
> 
> Diffs
> -----
> 
>   build.gradle fa3ed0d88bf6491007eabb2c44dfe78317fd87cf 
>   ui/package.json 38950567f1c3259f62bb53352477fb2d429c3276 
>   ui/plugin/js/components/Home.js PRE-CREATION 
>   ui/plugin/js/components/home.css PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63169/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message