aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 63157: Provide a formal way to disable offer declining
Date Thu, 19 Oct 2017 20:43:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63157/#review188753
-----------------------------------------------------------


Ship it!




Master (a9827fe) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 19, 2017, 4:23 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63157/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 4:23 p.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Increasing the offer hold time to effectively disable offer declines is a trap, as the
queue of asynchronous declines will grow without bound.  This introduces a command line argument
to explicitly disable declining.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md f4cc4163972ce516fd07747d004e0b8bfe5b2bd7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 7d3766829161457b1b3ba50bce128047d10b2c58

>   src/main/java/org/apache/aurora/scheduler/offers/OfferDecline.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java e8334310a2a46a0ccb09ee6e4122c515892d3996

>   src/main/java/org/apache/aurora/scheduler/offers/OfferSettings.java 4c6fd546a450917b7542329b020f42ef6379f3b7

>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java ab98addf6b63c3e4b97374c3d5adcd79ceec78c0

>   src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 8f4f63c73c2c2133c7beaf22e1abccfd966f542c

>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 815a7e8200ad7b25080556bddd54d407a74678cc

> 
> 
> Diff: https://reviews.apache.org/r/63157/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message