aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <jordan....@gmail.com>
Subject Re: Review Request 63132: Cosmetic changes to Navigation and task metadata
Date Thu, 19 Oct 2017 17:11:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63132/#review188698
-----------------------------------------------------------


Ship it!




Ship It!

- Jordan Ly


On Oct. 18, 2017, 11:38 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63132/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 11:38 p.m.)
> 
> 
> Review request for Aurora and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> More beta testing feedback: cosmetic changes to Navigation and task metadata.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/TaskConfigSummary.js 2a325d94ee3553000527641af6fd6e17c4c1238c

>   ui/src/main/sass/components/_job-page.scss 91b731f282c14cd0088f7e9085361a96fd62ade3

>   ui/src/main/sass/components/_navigation.scss ecf0ca6dd7128d90f367253e2403d22b269fa830

> 
> 
> Diff: https://reviews.apache.org/r/63132/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> See screenshots.
> 
> 
> File Attachments
> ----------------
> 
> Screen Shot 2017-10-18 at 4.36.43 PM.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/18/668c2fc0-6061-4fce-a676-ccd2a326f05a__Screen_Shot_2017-10-18_at_4.36.43_PM.png
> Screen Shot 2017-10-18 at 4.37.21 PM.png
>   https://reviews.apache.org/media/uploaded/files/2017/10/18/682ea38b-ed9f-460b-a1e2-f3133d3a5871__Screen_Shot_2017-10-18_at_4.37.21_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message