aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David McLaughlin <da...@dmclaughlin.com>
Subject Re: Review Request 63125: Add cron configuration to Job Page
Date Wed, 18 Oct 2017 21:40:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63125/
-----------------------------------------------------------

(Updated Oct. 18, 2017, 9:40 p.m.)


Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.


Changes
-------

lint fixes.


Repository: aurora


Description
-------

Adds cron configuration to Job Page.


Diffs (updated)
-----

  ui/.eslintrc f7ac075d8b0e65a2541bbee1bfd9e552f4eda95b 
  ui/src/main/js/components/JobConfig.js 275f46a88701f819007918faa3ad5a258880b308 
  ui/src/main/js/components/TaskConfigSummary.js 5c00d1e0a74a93d23b7f0e007efa6990befa6ffe

  ui/src/main/js/components/__tests__/JobConfig-test.js 59541d9afb22de036a0076360a0e8b915548a98b

  ui/src/main/js/pages/Job.js 6a9bd7e5e7a2d24df0a8e5b07830485ffe718d3d 
  ui/src/main/js/pages/__tests__/Job-test.js 09dd54ec0a49f425c7de18e9bb1a1b3e7b98a624 
  ui/src/main/js/utils/Thrift.js 4336bd1d62f145b38e667604c810436910e90b38 
  ui/src/main/sass/components/_job-page.scss cd038322ab12f5851d2e506887eddac503c62586 
  ui/test-setup.js a86a89a0a27b335b02cf514335e6ddd8f30b23c1 


Diff: https://reviews.apache.org/r/63125/diff/2/

Changes: https://reviews.apache.org/r/63125/diff/1-2/


Testing
-------

./gradlew ui:lint
./gradlew ui:test

See screenshot.


File Attachments
----------------

Screen Shot 2017-10-18 at 2.04.59 PM.png
  https://reviews.apache.org/media/uploaded/files/2017/10/18/c114ecb7-7b63-4bc4-9c44-e2b2c5f479b2__Screen_Shot_2017-10-18_at_2.04.59_PM.png


Thanks,

David McLaughlin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message