aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 63122: Remove corrupted fonts and add font files to .gitattributes to prevent line-ending formatting by git
Date Wed, 18 Oct 2017 21:18:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63122/#review188579
-----------------------------------------------------------


Ship it!




Master (f820b27) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 18, 2017, 8:25 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63122/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 8:25 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add .ttf files to .gitattributes to prevent corruption of binary files. The fonts are
broken on master due to rbt patch having converted their line-endings. 
> 
> I'll add the files back in a follow-up patch (wanted to make sure the old ones were gone).
> 
> 
> Diffs
> -----
> 
>   .gitattributes ba6fb66d07a8276721c1d81759929a2734e4e782 
>   ui/src/main/js/index.js 8cb449064322f3f4b5235b8db8ff47d5406b1055 
>   ui/src/main/resources/SourceSansPro-Black.ttf 489e65af8fa8aa6b930f2b10198a37df197f87f9

>   ui/src/main/resources/SourceSansPro-Bold.ttf b23d6f3e5ba167a6bf5897c9212cdf646c6e2553

>   ui/src/main/resources/SourceSansPro-Regular.ttf 1e077ba1cd5438db9f4fb91fd241aae9523b489e

>   ui/src/main/resources/SourceSansPro-Semibold.ttf f0d0ba4fd9483f067ce190bb2c3ba920b0e101c9

> 
> 
> Diff: https://reviews.apache.org/r/63122/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test (to verify not broken)
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message