aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 63038: Protect against null value in RoleQuota
Date Mon, 16 Oct 2017 18:22:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63038/#review188180
-----------------------------------------------------------


Ship it!




Ship It!

- Stephan Erb


On Okt. 16, 2017, 7:52 nachm., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63038/
> -----------------------------------------------------------
> 
> (Updated Okt. 16, 2017, 7:52 nachm.)
> 
> 
> Review request for Aurora, Kai Huang, Santhosh Kumar Shanmugham, and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix for bug that caused a race condition on the job/env page with exception "quota is
not defined".
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/RoleQuota.js 36a69b4c52777995006d105515379d2ed81a62d3 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js 57f332d51b4fc264ecf17020e2a75ab6bec9ffcb

> 
> 
> Diff: https://reviews.apache.org/r/63038/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:lint
> ./gradlew ui:test
> 
> Validated fix in Vagrant.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message