aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 62692: Move job environment validation to the scheduler.
Date Sat, 14 Oct 2017 23:46:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62692/#review188074
-----------------------------------------------------------


Ship it!




Master (2aee90d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 14, 2017, 11:29 p.m., Mauricio Garavaglia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62692/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2017, 11:29 p.m.)
> 
> 
> Review request for Aurora and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moves the job environment validation to the scheduler, which can be enabled with the
scheduler require_predefined_environments flag. This allows to have a consistent behavior
when using the CLI and the API. In order to preserve backward compatibility, the validation
is kept in the CLI and for the API it needs to be manually enabled in the scheduler.
> 
> 
> Diffs
> -----
> 
>   docs/features/multitenancy.md 301170daa5ecb92f748994c40bb3f9f1f3871e53 
>   docs/reference/configuration.md 0231c9265a8134e9b4541e131c3589c96df81274 
>   docs/reference/scheduler-configuration.md 4e3f90713c307e3b9e9f84c29343af7f014f0165

>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 54d7d4ce0e93ca2278bb5f176e633ad72991ee9d

>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 60bbe39d1282ccaa1bb91ad595412d55d115e6c5

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java b7f5e35079431d26065bc95430badb3e6d229a2a

>   src/main/python/apache/aurora/client/config.py 70c2c980309e18de576b251087cdfea00ac06b75

>   src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 9b4f2ad15ab5b61d4cccfad38ba48f17e7853425

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
265e87ea9ec0bf3a73a1b5e9d7c40e3d9c79e863 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 459d6bebcd7d6341dac2aead7e3dd8ce87bc9ed6

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java 3c5ecd698557cafdf8eeacdc472589a379018896

>   src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 2cd19d572d2945e28630b9bce5ba58eb9753630a

>   src/test/python/apache/aurora/client/test_config.py 042372e4d73bee9cedb7f0fc5cfd009bc766aee2

> 
> 
> Diff: https://reviews.apache.org/r/62692/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mauricio Garavaglia
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message