aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 62835: Use compatible Curator session and connection timeouts
Date Fri, 13 Oct 2017 14:56:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62835/#review187964
-----------------------------------------------------------


Ship it!




Master (2aee90d) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 13, 2017, 4:36 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62835/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2017, 4:36 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, John Sirois, Renan DelValle, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Curator will warn if used with a connection timeout that is lower than
> the session timeout [1]. As it uses a default connection timeout of 15s
> [2], this warning will be emitted using the Aurora default settings.
> 
> This patch remedies this issue in two ways:
> 
> * Making the Curator connection timeout configurable
> * Bumping the session timeout to 15s. The current default of 4s is
>   pretty small and could lead to unexpected failovers during long GC
>   pauses. This is especially problematic as a failover in Aurora can
>   be lengthy.
> 
> [1] https://github.com/apache/curator/blob/15eb063fa22569e797f850fb8d60a0949f52fbf5/curator-client/src/main/java/org/apache/curator/CuratorZookeeperClient.java#L118-L121
> [2] https://github.com/apache/curator/blob/6ba4de36d4e8b2b65d45c005a6a92dd85c3c497f/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java#L60-L61
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md c58e68080beb1740d92639601ef7cc29c63be37e 
>   commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java 2ada2646da7bdc3276803336cc638e23b9e61d26

>   src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
ea167a89a95f0f35d53a34631ae44e0a911a6817 
>   src/main/java/org/apache/aurora/scheduler/discovery/FlaggedZooKeeperConfig.java c2e8ce24bbb029a1c52cbdabce19a98029bc33f2

>   src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java f6faca56cbfceeb9e1226c0e8feec13c7c772d94

>   src/test/java/org/apache/aurora/scheduler/config/CommandLineTest.java 9b4f2ad15ab5b61d4cccfad38ba48f17e7853425

>   src/test/java/org/apache/aurora/scheduler/discovery/AbstractDiscoveryModuleTest.java
0f2121ef1453b41286f9713d5ce89a26d1cb1b4f 
>   src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java a065505134c1ad30ba9f4d4cd829355b2acc9a13

> 
> 
> Diff: https://reviews.apache.org/r/62835/diff/2/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message