aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <>
Subject Re: Review Request 62835: Use compatible Curator session and connection timeouts
Date Fri, 13 Oct 2017 14:36:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 13, 2017, 4:36 p.m.)

Review request for Aurora, David McLaughlin, John Sirois, Renan DelValle, and Bill Farner.


Review changes + rebase

Repository: aurora


Curator will warn if used with a connection timeout that is lower than
the session timeout [1]. As it uses a default connection timeout of 15s
[2], this warning will be emitted using the Aurora default settings.

This patch remedies this issue in two ways:

* Making the Curator connection timeout configurable
* Bumping the session timeout to 15s. The current default of 4s is
  pretty small and could lead to unexpected failovers during long GC
  pauses. This is especially problematic as a failover in Aurora can
  be lengthy.


Diffs (updated)
----- c58e68080beb1740d92639601ef7cc29c63be37e 
  commons/src/main/java/org/apache/aurora/common/zookeeper/ 2ada2646da7bdc3276803336cc638e23b9e61d26

  src/main/java/org/apache/aurora/scheduler/discovery/ ea167a89a95f0f35d53a34631ae44e0a911a6817

  src/main/java/org/apache/aurora/scheduler/discovery/ c2e8ce24bbb029a1c52cbdabce19a98029bc33f2

  src/main/java/org/apache/aurora/scheduler/discovery/ f6faca56cbfceeb9e1226c0e8feec13c7c772d94

  src/test/java/org/apache/aurora/scheduler/config/ 9b4f2ad15ab5b61d4cccfad38ba48f17e7853425

  src/test/java/org/apache/aurora/scheduler/discovery/ 0f2121ef1453b41286f9713d5ce89a26d1cb1b4f

  src/test/java/org/apache/aurora/scheduler/discovery/ a065505134c1ad30ba9f4d4cd829355b2acc9a13




./gradlew -Pq build


Stephan Erb

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message