aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 62955: Manage Bootstrap with webpack in new UI
Date Thu, 12 Oct 2017 22:38:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62955/#review187883
-----------------------------------------------------------



Master (2aee90d) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Oct. 12, 2017, 10:22 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62955/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 10:22 p.m.)
> 
> 
> Review request for Aurora, Kai Huang and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This serves bootstrap and all static dependencies via the UI bundle generated by webpack.
It means we can remove the vendored code from the repo when we delete the old UI. In additon,
the Scheduler no longer has to serve them as resources.
> 
> 
> Diffs
> -----
> 
>   .gitignore 2f24af533a93615df9545a99a3acaa86ed9e2bc5 
>   src/main/resources/scheduler/assets/scheduler/new-index.html d59a6f50bd8661e38e796f4b087bc25a09adb061

>   ui/package.json cde8d106346d9ac498cfee9b5291ebc637fc6a2a 
>   ui/src/main/js/index.js 13d722fa06f7c5c86f16eae772367f1438ad795f 
>   ui/webpack.config.js 4fd7b352627ac8e3dc55efc4fadb17a96894b937 
> 
> 
> Diff: https://reviews.apache.org/r/62955/diff/1/
> 
> 
> Testing
> -------
> 
> Verified bootstrap styles and fonts (icons) are still applied in Vagrant.
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message