aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephan Erb <s...@apache.org>
Subject Re: Review Request 62873: Stream backup file from disk
Date Tue, 10 Oct 2017 21:39:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62873/#review187594
-----------------------------------------------------------


Ship it!





src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java
Line 143 (original), 146 (patched)
<https://reviews.apache.org/r/62873/#comment264614>

    Bill, totally unrelated question: Has anyone of you ever experimented with the TCompactProtocol
rather than the TBinaryProtocol? 
    
    I have heard rumors that it should be smaller while providing similar performance. So,
it might be worth a try for our IO bound operations.


- Stephan Erb


On Oct. 10, 2017, 10:35 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62873/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2017, 10:35 p.m.)
> 
> 
> Review request for Aurora and Jordan Ly.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This reduces the memory burden of loading a backup for recovery.  Previously, the backup
file would be fully loaded into a `byte[]`, which may be very large and fail to allocate.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java b74de9b51fd01788a3970e56a534a3b9adcd8863

> 
> 
> Diff: https://reviews.apache.org/r/62873/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message