aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <>
Subject Re: Review Request 62700: Convert Webhook to AbstractIdleService, use async HTTP client
Date Tue, 03 Oct 2017 17:01:55 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 3, 2017, 5:01 p.m.)

Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, Stephan Erb, and Bill


Remove unused import.

Bugs: AURORA-1773

Repository: aurora



>From the above review: "Current code uses a synchronous HTTP client, which can block the
EventBus. Switch to an async HTTP client."

Previously, we had an issue where the HTTP client would have a non-daemon thread which caused
the Scheduler to fail to shutdown. I converted it into an AbstractIdleService and properly
closed the client in the shutdown() method. Additionally, I made a small tweak to the original
code where we ABORT any response receieved after the status since we don't care. We just use
the response code for stats.

Diffs (updated)

  build.gradle f9579a38de95ff9e11cf2e44980d01e103226389 
  src/main/java/org/apache/aurora/scheduler/events/ 05f46a1946e062ac57cca828c094586f4c983f45

  src/main/java/org/apache/aurora/scheduler/events/ da22c218c5fbe6607552edbb4f8e52850d718851

  src/main/java/org/apache/aurora/scheduler/events/ 1f10af71830386652d21961b733bd0927c5436a1

  src/test/java/org/apache/aurora/scheduler/events/ 07f39fa487e0ebd2252568750d5f36ac200a96aa




./gradlew test

Tested proper shutdown occurs in Vagrant.

Scale tested up to 2000 TASK_LOST events with the registered endpoint waiting 5-10 minutes
to response -- does not seem to block scheduling.


Jordan Ly

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message