Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 11D7B200D18 for ; Wed, 27 Sep 2017 02:25:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1035B1609EA; Wed, 27 Sep 2017 00:25:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 558481609D7 for ; Wed, 27 Sep 2017 02:25:58 +0200 (CEST) Received: (qmail 69554 invoked by uid 500); 27 Sep 2017 00:25:57 -0000 Mailing-List: contact reviews-help@aurora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.apache.org Delivered-To: mailing list reviews@aurora.apache.org Received: (qmail 69543 invoked by uid 99); 27 Sep 2017 00:25:57 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2017 00:25:57 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CF0201A2BC4; Wed, 27 Sep 2017 00:25:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.999 X-Spam-Level: ** X-Spam-Status: No, score=2.999 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id gpBDLz6Ftzc9; Wed, 27 Sep 2017 00:25:55 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5791961023; Wed, 27 Sep 2017 00:25:55 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5C676E0059; Wed, 27 Sep 2017 00:25:54 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id 99A56C4016D; Wed, 27 Sep 2017 00:25:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4492843058061857249==" MIME-Version: 1.0 Subject: Re: Review Request 62604: Use a more efficient query for instance ID collision detection From: Bill Farner To: Jordan Ly Cc: Bill Farner , Aurora Date: Wed, 27 Sep 2017 00:25:54 -0000 Message-ID: <20170927002554.42295.63194@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Bill Farner X-ReviewGroup: Aurora X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/62604/ X-Sender: Bill Farner References: <20170927001007.42294.6677@reviews-vm2.apache.org> In-Reply-To: <20170927001007.42294.6677@reviews-vm2.apache.org> Reply-To: Bill Farner X-ReviewRequest-Repository: aurora archived-at: Wed, 27 Sep 2017 00:25:59 -0000 --===============4492843058061857249== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62604/ ----------------------------------------------------------- (Updated Sept. 26, 2017, 5:25 p.m.) Review request for Aurora and Jordan Ly. Repository: aurora Description ------- Came across this while looking at storage access patterns. Not a particularly hot code path, but this is more efficient and concise. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 6b780ec90fed846531162eed5e86336e598e33a3 Diff: https://reviews.apache.org/r/62604/diff/2/ Changes: https://reviews.apache.org/r/62604/diff/1-2/ Testing ------- Thanks, Bill Farner --===============4492843058061857249==--