aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David McLaughlin <da...@dmclaughlin.com>
Subject Re: Review Request 62451: Implement Role and Environment pages in Preact.
Date Thu, 28 Sep 2017 01:28:04 GMT


> On Sept. 26, 2017, 12:27 a.m., Santhosh Kumar Shanmugham wrote:
> > ui/src/main/js/components/JobList.js
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/62451/diff/1/?file=1832476#file1832476line97>
> >
> >     It is possible for clusters to have customer tier configuration. Should we make
this read that configuration?
> >     
> >     http://aurora.apache.org/documentation/latest/features/multitenancy/
> 
> David McLaughlin wrote:
>     Maybe in a future patch (although I'd question the value tbh). I'll just keep parity
with the existing UI for now.
> 
> Santhosh Kumar Shanmugham wrote:
>     I'm just worried about the hardcoding of `preferred` here, since different clusters
could have different tier names.
>     
>     In the old UI the tier is never used while displaying the summary - https://github.com/apache/aurora/blob/c85bffdd6f68312261697eee868d57069adda434/src/main/resources/scheduler/assets/js/controllers.js#L134-L142

You're right, I'll address.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186169
-----------------------------------------------------------


On Sept. 28, 2017, 12:18 a.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 28, 2017, 12:18 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements
aren't final yet - the plan is to wait until the structure is all in place and then go back
and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states
and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/JobListItem.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/Pagination.js dec89be93d531f755097ac8b3ee48d643d31262f 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/js/utils/Job.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 2ea60bc64ccb2b556ef6edf25016f6a01cd075f6 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/3/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message