aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Reza Motamedi <reza.motam...@gmail.com>
Subject Re: Review Request 62626: Added additional stop() to prevent errors in run() to stop shutdown in SchedulerMain
Date Wed, 27 Sep 2017 20:33:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62626/#review186473
-----------------------------------------------------------




src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java
Line 109 (original), 109 (patched)
<https://reviews.apache.org/r/62626/#comment263029>

    Is just testing shutdown of the leader? Should we have separate tests the followers then?


- Reza Motamedi


On Sept. 27, 2017, 8:25 p.m., Jordan Ly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62626/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 8:25 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-1950
>     https://issues.apache.org/jira/browse/AURORA-1950
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Ensure that `SchedulerMain.run()` calls stop in the case of exceptions. This prevents
the Scheduler from being transitioned to DEAD state, but not actually stopping it's services.
> 
> See the attached ticket for an example of issue happening.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3fbe99c4f1af1f11403bf08155bb4be028132e38

>   src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 70479ef8be324bf2e382b0d2ad594c2eb33c931c

> 
> 
> Diff: https://reviews.apache.org/r/62626/diff/1/
> 
> 
> Testing
> -------
> 
> Added an additional unit test for prepare() failing in `SchedulerLifecycle.java`.
> 
> ./gradlew test
> ./build-support/jenkin/build.sh
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message