aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jordan Ly <jordan....@gmail.com>
Subject Review Request 62626: Added additional stop() to prevent errors in run() to stop shutdown in SchedulerMain
Date Wed, 27 Sep 2017 20:25:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62626/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Bill Farner.


Bugs: AURORA-1950
    https://issues.apache.org/jira/browse/AURORA-1950


Repository: aurora


Description
-------

Ensure that `SchedulerMain.run()` calls stop in the case of exceptions. This prevents the
Scheduler from being transitioned to DEAD state, but not actually stopping it's services.

See the attached ticket for an example of issue happening.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3fbe99c4f1af1f11403bf08155bb4be028132e38

  src/test/java/org/apache/aurora/scheduler/SchedulerLifecycleTest.java 70479ef8be324bf2e382b0d2ad594c2eb33c931c



Diff: https://reviews.apache.org/r/62626/diff/1/


Testing
-------

Added an additional unit test for prepare() failing in `SchedulerLifecycle.java`.

./gradlew test
./build-support/jenkin/build.sh


Thanks,

Jordan Ly


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message