aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aurora ReviewBot <wfar...@apache.org>
Subject Re: Review Request 62621: Allow transitions from any state to STOPPED in CallOrderEnforcingStorage
Date Wed, 27 Sep 2017 18:20:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62621/#review186455
-----------------------------------------------------------



Master (474320b) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Sept. 27, 2017, 5:25 p.m., Jordan Ly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62621/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 5:25 p.m.)
> 
> 
> Review request for Aurora, Santhosh Kumar Shanmugham, Stephan Erb, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Allow transitions from any state to STOPPED in CallOrderEnforcingStorage, including
adding a STOPPED -> STOPPED transition so stop() can be used idempotent.
> - Use the StateMachines.checkState method (I wasn't sure if the current checkInState
was designed for anything other than throwing a TransientStorageException)
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 2a5ec9c912979811c4badeee9362c22184d9cbbf

>   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 859c96414fbafc1742c77c4bf9bff889d2efa31c

> 
> 
> Diff: https://reviews.apache.org/r/62621/diff/3/
> 
> 
> Testing
> -------
> 
> No unit tests specified.
> ./gradlew test
> 
> 
> Thanks,
> 
> Jordan Ly
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message