aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Santhosh Kumar Shanmugham <santhoshkuma...@gmail.com>
Subject Re: Review Request 62451: Implement Role and Environment pages in Preact.
Date Tue, 26 Sep 2017 00:27:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62451/#review186169
-----------------------------------------------------------



Mostly looks good to me. I have not reviewed the tests since they will be rewritten.


ui/src/main/js/components/JobList.js
Lines 15 (patched)
<https://reviews.apache.org/r/62451/#comment262618>

    nit - Can we use `k.replace('TaskCount', '')` here as well like below?



ui/src/main/js/components/JobList.js
Lines 97 (patched)
<https://reviews.apache.org/r/62451/#comment262626>

    It is possible for clusters to have customer tier configuration. Should we make this read
that configuration?
    
    http://aurora.apache.org/documentation/latest/features/multitenancy/



ui/src/main/js/components/RoleQuota.js
Lines 26 (patched)
<https://reviews.apache.org/r/62451/#comment262628>

    Wonder if we should show the usage as percentage and on the side indicate the absolute
amount. Probably in a custom component. Not a blocker though.



ui/src/main/js/components/RoleQuota.js
Lines 57 (patched)
<https://reviews.apache.org/r/62451/#comment262636>

    Curious - I do not get the intent of calling this `aurora-table`. Are you setting this
up for something in the future?


- Santhosh Kumar Shanmugham


On Sept. 21, 2017, 4:17 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62451/
> -----------------------------------------------------------
> 
> (Updated Sept. 21, 2017, 4:17 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kai Huang, and Santhosh Kumar Shanmugham.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implement Role and Environment pages in Preact. The color scheme and other design elements
aren't final yet - the plan is to wait until the structure is all in place and then go back
and style things. 
> 
> Major difference from the current UI is the use of color to visualize the task states
and the move away from the table format of the data.
> 
> 
> Diffs
> -----
> 
>   ui/src/main/js/components/JobList.js PRE-CREATION 
>   ui/src/main/js/components/Layout.js PRE-CREATION 
>   ui/src/main/js/components/RoleQuota.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/JobList-test.js PRE-CREATION 
>   ui/src/main/js/components/__tests__/RoleQuota-test.js PRE-CREATION 
>   ui/src/main/js/index.js 717aaa080d1365785a603ed7d1ece69efdaafec7 
>   ui/src/main/js/pages/Jobs.js PRE-CREATION 
>   ui/src/main/js/pages/__tests__/Jobs-test.js PRE-CREATION 
>   ui/src/main/js/utils/Common.js PRE-CREATION 
>   ui/src/main/sass/app.scss 0b3967d39ed443eaf5bfadb473816135e0a978e4 
>   ui/src/main/sass/components/_job-list-page.scss PRE-CREATION 
>   ui/src/main/sass/components/_layout.scss b8a83b585fcef11964dc8349703ad453d37b5d2d 
>   ui/src/main/sass/components/_tables.scss 58f176cffcdae34de7c776e31b3f0342efa3024f 
>   ui/src/main/sass/modules/_colors.scss 147cff691058972aebc5f79f22955cf2448ce48c 
> 
> 
> Diff: https://reviews.apache.org/r/62451/diff/1/
> 
> 
> Testing
> -------
> 
> ./gradlew ui:test
> ./gradlew ui:lint
> 
> See screenshot for local development with some Twitter data.
> 
> 
> File Attachments
> ----------------
> 
> Screenshot 
>   https://reviews.apache.org/media/uploaded/files/2017/09/21/684d8630-a9b4-4fbf-8955-a7fc118afcce__Screen_Shot_2017-09-21_at_4.11.05_PM.png
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message